From: Patrick McHardy <kaber@trash.net>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Joonwoo Park <joonwpark81@gmail.com>,
netdev@vger.kernel.org, "'David Miller'" <davem@davemloft.net>,
linux-kernel@vger.kernel.org, greearb@candelatech.com, w@1wt.eu,
cfriesen@nortel.com,
djohnson+linux-kernel@sw.starentnetworks.com,
e1000-devel@lists.sourceforge.net, "'Kok,
Auke'" <auke-jan.h.kok@intel.com>
Subject: Re: FW: [PATCH 2/2] [e1000 VLAN] Disable vlan hw accel when promiscuous mode
Date: Fri, 16 Nov 2007 15:46:26 +0100 [thread overview]
Message-ID: <473DAD42.60603@trash.net> (raw)
In-Reply-To: <20071116143348.GA10596@gondor.apana.org.au>
Herbert Xu wrote:
> BTW, how does the VLAN TX acceleration work at all? It's using
> skb->cb to carry the tags but then calls dev_queue_xmit. Once
> you do that packet schedulers can scribble all over skb->cb.
>
> Also vlan_skb_recv should be moved out-of-line. It's absolutely
> humongous. It'll generate tail-calls anyway so performance-wise
> it's useless.
I have a number of VLAN cleanups queued and intend to do these
two changes on top.
WARNING: multiple messages have this Message-ID (diff)
From: Patrick McHardy <kaber@trash.net>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "'Kok, Auke'" <auke-jan.h.kok@intel.com>,
e1000-devel@lists.sourceforge.net, netdev@vger.kernel.org,
djohnson+linux-kernel@sw.starentnetworks.com,
linux-kernel@vger.kernel.org,
Joonwoo Park <joonwpark81@gmail.com>,
'David Miller' <davem@davemloft.net>,
cfriesen@nortel.com, greearb@candelatech.com, w@1wt.eu
Subject: Re: FW: [PATCH 2/2] [e1000 VLAN] Disable vlan hw accel when promiscuous mode
Date: Fri, 16 Nov 2007 15:46:26 +0100 [thread overview]
Message-ID: <473DAD42.60603@trash.net> (raw)
In-Reply-To: <20071116143348.GA10596@gondor.apana.org.au>
Herbert Xu wrote:
> BTW, how does the VLAN TX acceleration work at all? It's using
> skb->cb to carry the tags but then calls dev_queue_xmit. Once
> you do that packet schedulers can scribble all over skb->cb.
>
> Also vlan_skb_recv should be moved out-of-line. It's absolutely
> humongous. It'll generate tail-calls anyway so performance-wise
> it's useless.
I have a number of VLAN cleanups queued and intend to do these
two changes on top.
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
next prev parent reply other threads:[~2007-11-16 14:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-16 11:49 FW: [PATCH 2/2] [e1000 VLAN] Disable vlan hw accel when promiscuous mode Joonwoo Park
2007-11-16 11:49 ` Joonwoo Park
2007-11-16 14:33 ` Herbert Xu
2007-11-16 14:46 ` Patrick McHardy [this message]
2007-11-16 14:46 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=473DAD42.60603@trash.net \
--to=kaber@trash.net \
--cc=auke-jan.h.kok@intel.com \
--cc=cfriesen@nortel.com \
--cc=davem@davemloft.net \
--cc=djohnson+linux-kernel@sw.starentnetworks.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=greearb@candelatech.com \
--cc=herbert@gondor.apana.org.au \
--cc=joonwpark81@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.