Re: [PATCH] mkdevicemap for Cygwin

[Christian Franke <Christian.Franke@t-online.de>]

Marco Gerards wrote:
> Christian Franke <Christian.Franke@t-online.de> writes:
>
>   
>> Some changes for grub-mkdevicemap on Cygwin.
>>
>> Christian
>>
>> 2007-11-13  Christian Franke  <franke@computer.org>
>>
>> 	* util/grub-mkdevicemap.c (get_floppy_disk_name): Add Cygwin
>> 	device names.
>> 	(get_ide_disk_name): Disable on __CYGWIN__.
>>     
>
>         [__CYGWIN__] (get_ide_disk_name): Disable.
>
>   
>> 	(get_scsi_disk_name): Add Cygwin device names.
>> 	(check_device): Add static.
>> 	Return error instead of success on empty string.
>>     
>
> Can you explain this?  Does this break something on GNU/Linux?
>
>   

See last mail. Should not break GNU/Linux, because (*name = 0) is not 
used then.


>> 	(make_device_map): Disable IDE loop on __CYGWIN__.
>>     
>
>         [__CYGWIN__] (make_device_map): Disable IDE loop.
>
>   
>> 	Move label inside linux specific code to prevent compiler warning.
>>     
>
>         (make_device_map): Move label inside linux specific code to
>         prevent compiler warning.
>
> Otherwise fine, so this can be committed if there aren't any other
> problems with this patch.
>   

Thanks, new changelog below.

Christian

2007-11-18  Christian Franke  <franke@computer.org>

	* util/grub-mkdevicemap.c (get_floppy_disk_name): Add Cygwin
	device names.
	[__CYGWIN__] (get_ide_disk_name): Disable.
	(get_scsi_disk_name): Add Cygwin device names.
	(check_device): Add static.
	Return error instead of success on empty string.
	[__CYGWIN__] (make_device_map): Disable IDE loop.
	(make_device_map): Move label inside linux specific code to
	prevent compiler warning.