From: Rene Herman <rene.herman@keyaccess.nl>
To: trenn@suse.de
Cc: ALSA devel <alsa-devel@alsa-project.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
"yakui.zhao" <yakui.zhao@intel.com>,
"Li, Shaohua" <shaohua.li@intel.com>,
akpm <akpm@linux-foundation.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Bjorn Helgaas <bjorn.helgaas@hp.com>
Subject: Re: [PATCH 2/3] PNP cleanups - Unify the pnp macros to access resources in the pnp resource table
Date: Tue, 20 Nov 2007 15:31:26 +0100 [thread overview]
Message-ID: <4742EFBE.6030407@keyaccess.nl> (raw)
In-Reply-To: <1195568360.23700.202.camel@queen.suse.de>
On 20-11-07 15:19, Thomas Renninger wrote:
> At the end is some example code how things could get even more cleaned
> up. It shows how I think pnp layer and one example driver would get
> adjusted. There are not that much drivers making use of
> pnp_resource_change...
The ALSA ISA-PnP drivers do in what I personally consider a bad layering
violation. Brought up not doing that a while ago on alsa-devel, but no
discussion ensued. If the PnP maintainer(s) agree with me though, I'd be
more than happy to rip all of that out of ALSA.
(added alsa-devel)
Rene.
WARNING: multiple messages have this Message-ID (diff)
From: Rene Herman <rene.herman@keyaccess.nl>
To: trenn@suse.de
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
linux-kernel <linux-kernel@vger.kernel.org>,
Bjorn Helgaas <bjorn.helgaas@hp.com>,
"Li, Shaohua" <shaohua.li@intel.com>,
"yakui.zhao" <yakui.zhao@intel.com>,
akpm <akpm@linux-foundation.org>,
ALSA devel <alsa-devel@alsa-project.org>
Subject: Re: [PATCH 2/3] PNP cleanups - Unify the pnp macros to access resources in the pnp resource table
Date: Tue, 20 Nov 2007 15:31:26 +0100 [thread overview]
Message-ID: <4742EFBE.6030407@keyaccess.nl> (raw)
In-Reply-To: <1195568360.23700.202.camel@queen.suse.de>
On 20-11-07 15:19, Thomas Renninger wrote:
> At the end is some example code how things could get even more cleaned
> up. It shows how I think pnp layer and one example driver would get
> adjusted. There are not that much drivers making use of
> pnp_resource_change...
The ALSA ISA-PnP drivers do in what I personally consider a bad layering
violation. Brought up not doing that a while ago on alsa-devel, but no
discussion ensued. If the PnP maintainer(s) agree with me though, I'd be
more than happy to rip all of that out of ALSA.
(added alsa-devel)
Rene.
next prev parent reply other threads:[~2007-11-20 14:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-20 9:51 [PATCH 2/3] PNP cleanups - Unify the pnp macros to access resources in the pnp resource table Thomas Renninger
2007-11-20 10:17 ` Rene Herman
2007-11-20 12:31 ` Alan Cox
2007-11-20 14:19 ` Thomas Renninger
2007-11-20 14:31 ` Rene Herman [this message]
2007-11-20 14:31 ` Rene Herman
2007-11-20 16:48 ` Thomas Renninger
2007-11-21 9:53 ` Takashi Iwai
2007-11-21 9:53 ` [alsa-devel] " Takashi Iwai
2007-11-27 16:34 ` Thomas Renninger
2007-11-27 16:34 ` [alsa-devel] " Thomas Renninger
2007-11-27 16:52 ` Rene Herman
2007-11-27 16:52 ` [alsa-devel] " Rene Herman
2007-11-20 15:14 ` Alan Cox
2007-11-20 18:59 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4742EFBE.6030407@keyaccess.nl \
--to=rene.herman@keyaccess.nl \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=alsa-devel@alsa-project.org \
--cc=bjorn.helgaas@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shaohua.li@intel.com \
--cc=trenn@suse.de \
--cc=yakui.zhao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.