Re: [oe-commits] org.oe.dev Add cryptsetup: cryptsetup with luks support creates and manages encrypted containers and partitions

Re: [oe-commits] org.oe.dev Add cryptsetup: cryptsetup with luks support creates and manages encrypted containers and partitions

[Koen Kooi]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

coredump2 commit schreef:


> +######################################################################################
> +######################################################################################
> +######################################################################################
> +######################################################################################

Please read (and follow) the styleguide and run the recipe through
OE-stylize.py to get an idea how it should look like.



> +pkg_postinst() {
> +	if test "x$D" = "x"
> +	then 
> +		# Work around a problem in module ipk's, where depmod is not always
> +		# run after installing a kernel-module.
> +		test -x /sbin/depmod && /sbin/depmod -a
> +		/bin/true
> +	fi

And don't add such hacks, please remove it.


- --
koen@dominion.kabel.utwente.nl will go go away in december 2007, please
use k.kooi@student.utwente.nl instead.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFHQ0uzMkyGM64RGpERAr6iAJ9zEuSosMdbDNhiUYbYx/UA8N+OpwCfXTO9
yt+9HhZoJGQV8fWr57FAmTs=
=JSkU
-----END PGP SIGNATURE-----

Re: [oe-commits] org.oe.dev Add cryptsetup: Stop forcing your opinions onto other people!

[Matthias Hentges]

[-- Attachment #1: Type: text/plain, Size: 2063 bytes --]

For starters, this mailing list is still broken and violates RFCs in
regards to FROM and REPLY-TO.

Am Dienstag, den 20.11.2007, 22:03 +0100 schrieb Koen Kooi:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> coredump2 commit schreef:
> 
> 
> > +######################################################################################
> > +######################################################################################
> > +######################################################################################
> > +######################################################################################
> 
> Please read (and follow) the styleguide and run the recipe through
> OE-stylize.py to get an idea how it should look like.

Nice "style". With my layout, you at least had a sense about what does
what, the entries were grouped for easy reading.

Your "style" does nothing more than remove any kind of possible grouping
by deleting linefeeds left and right. Your "style" stinks.


> > +pkg_postinst() {
> > +	if test "x$D" = "x"
> > +	then 
> > +		# Work around a problem in module ipk's, where depmod is not always
> > +		# run after installing a kernel-module.
> > +		test -x /sbin/depmod && /sbin/depmod -a
> > +		/bin/true
> > +	fi
> 
> And don't add such hacks, please remove it.
> 

The "hack" had a very valid purpose. I even explained the purpose for
you alone in the .bb. It worked around a very real bug in module
handling which no one (not even you) bothered to fix for > 1 year.
A bug which is *impossible* to track-down or fix for most end-users.

Would be PLEASE STOP MESSING WITH OTHER PEOPLES FILES??
Only because YOU do not like something does NOT give you the bloody
right to revert or even change other peoples commits!

THIS IS NOT KOEN-EMBEDDED
-- 
Matthias 'CoreDump' Hentges 
Cologne / Germany

Webmaster of Hentges.net & Embedded Linux Developer
GPG ->  gpg --keyserver gpg-keyserver.de --recv-keys 0xAF3030D9

My OS: Debian SID: Geek by Nature, Linux by Choice



[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 196 bytes --]

Re: [oe-commits] org.oe.dev Add cryptsetup: Stop forcing your opinions onto other people!

[Matthias Hentges]

(due to the retarded ML server, this message may appear twice)

For starters, this mailing list is still broken and violates RFCs in
regards to FROM and REPLY-TO.

Am Dienstag, den 20.11.2007, 22:03 +0100 schrieb Koen Kooi:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> coredump2 commit schreef:
> 
> 
> > +######################################################################################
> > +######################################################################################
> > +######################################################################################
> > +######################################################################################
> 
> Please read (and follow) the styleguide and run the recipe through
> OE-stylize.py to get an idea how it should look like.

Nice "style". With my layout, you at least had a sense about what does
what, the entries were grouped for easy reading.

Your "style" does nothing more than remove any kind of possible grouping
by deleting linefeeds left and right. Your "style" stinks.


> > +pkg_postinst() {
> > +	if test "x$D" = "x"
> > +	then 
> > +		# Work around a problem in module ipk's, where depmod is not always
> > +		# run after installing a kernel-module.
> > +		test -x /sbin/depmod && /sbin/depmod -a
> > +		/bin/true
> > +	fi
> 
> And don't add such hacks, please remove it.
> 

The "hack" had a very valid purpose. I even explained the purpose for
you alone in the .bb. It worked around a very real bug in module
handling which no one (not even you) bothered to fix for > 1 year.
A bug which is *impossible* to track-down or fix for most end-users.

Would be PLEASE STOP MESSING WITH OTHER PEOPLES FILES??
Only because YOU do not like something does NOT give you the bloody
right to revert or even change other peoples commits!

THIS IS NOT KOEN-EMBEDDED
-- 
Matthias 'CoreDump' Hentges 
Cologne / Germany

Webmaster of Hentges.net & Embedded Linux Developer
GPG ->  gpg --keyserver gpg-keyserver.de --recv-keys 0xAF3030D9

My OS: Debian SID: Geek by Nature, Linux by Choice

Re: [oe-commits] org.oe.dev Add cryptsetup: Stop forcing your opinions onto other people!

[Koen Kooi]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Matthias Hentges schreef:

>>> +######################################################################################
>>> +######################################################################################
>>> +######################################################################################
>>> +######################################################################################
>> Please read (and follow) the styleguide and run the recipe through
>> OE-stylize.py to get an idea how it should look like.
> 
> Nice "style". With my layout, you at least had a sense about what does
> what, the entries were grouped for easy reading.
> 
> Your "style" does nothing more than remove any kind of possible grouping
> by deleting linefeeds left and right. Your "style" stinks.

It's not my style, it's the official OE style, which you would have
known if you had bothered to read the OE styleguide, as I said in my
original mail.
Oe-stylize.py showed a pile of other problems in your recipe on top of
those mentioned. So both the official style guide and the dedicated tool
back me up.

>>> +pkg_postinst() {
>>> +	if test "x$D" = "x"
>>> +	then 
>>> +		# Work around a problem in module ipk's, where depmod is not always
>>> +		# run after installing a kernel-module.
>>> +		test -x /sbin/depmod && /sbin/depmod -a
>>> +		/bin/true
>>> +	fi
>> And don't add such hacks, please remove it.
>>
> 
> The "hack" had a very valid purpose. 

Valid purpose or not, it doesn't belong in OE. By your reasoning we
should add all postinsts from all dependencies to each recipe. And *if*
postinst get mysteriously skipped, your hack isn't going to get
executed, is it?

> It worked around a very real bug

Yet a search in bugzilla for 'depmod' or 'postinst' yields no open bugs
on that.
The only 'bug' I know of is people using 'su' instead of 'su -' to
become root and (/usr)/sbin isn't in $PATH. That's PEBKAC, not an OE bug
or ipkg bug.

> Would be PLEASE STOP MESSING WITH OTHER PEOPLES FILES??

Not if those violate various *documented* OE policies and the author of
thw recipes in question refuses to comply with them.

> THIS IS NOT KOEN-EMBEDDED

No, this is OpenEmbedded, so follow the OE policies.

- --
koen@dominion.kabel.utwente.nl will go go away in december 2007, please
use k.kooi@student.utwente.nl instead.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFHRIDZMkyGM64RGpERAurqAKC03wbfp+wiE1Vd6F49vM/h6N4ecwCfdVue
+P0il0YgJpgJFq03bl859IE=
=IUQI
-----END PGP SIGNATURE-----

Re: [oe-commits] org.oe.dev Add cryptsetup: Stop forcing your opinions onto other people!

[Chris Larson]

On Nov 21, 2007 12:02 PM, Koen Kooi <k.kooi@student.utwente.nl> wrote:
> The only 'bug' I know of is people using 'su' instead of 'su -' to
> become root and (/usr)/sbin isn't in $PATH. That's PEBKAC, not an OE bug
> or ipkg bug.

Deviating from the discussion, but if the postinst relies on /sbin
being in the path for it to execute correctly, it should be fixed to
either modify the path or directly call the binary with the full path.
 No portable shell script should rely on anything but /bin and
/usr/bin being in the PATH.
-- 
Chris Larson - clarson at kergoth dot com
Dedicated Engineer - MontaVista - clarson at mvista dot com
Core Developer/Architect - TSLib, BitBake, OpenEmbedded, OpenZaurus