All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roel Kluin <12o3l@tiscali.nl>
To: linux-serial@vger.kernel.org
Subject: questions regarding function autoconfig(); drivers/serial/8250.c
Date: Fri, 23 Nov 2007 23:42:38 +0100	[thread overview]
Message-ID: <4747575E.80501@tiscali.nl> (raw)

In drivers/serial/8250.c:995 it reads:

if (!up->port.iobase && !up->port.mapbase && !up->port.membase)
	return;

As you can see the test !up->port.mapbase is duplicated, which makes no sense.
maybe a different test was intended here?
also since membase is a pointer shouldn't the '&&' be replaced with '||'?

thanks,

Roel

             reply	other threads:[~2007-11-23 22:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-23 22:42 Roel Kluin [this message]
2007-11-26 12:46 ` questions regarding function autoconfig(); drivers/serial/8250.c Uwe Kleine-König
2007-11-26 17:40   ` Roel Kluin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4747575E.80501@tiscali.nl \
    --to=12o3l@tiscali.nl \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.