* questions regarding function autoconfig(); drivers/serial/8250.c @ 2007-11-23 22:42 Roel Kluin 2007-11-26 12:46 ` Uwe Kleine-König 0 siblings, 1 reply; 3+ messages in thread From: Roel Kluin @ 2007-11-23 22:42 UTC (permalink / raw) To: linux-serial In drivers/serial/8250.c:995 it reads: if (!up->port.iobase && !up->port.mapbase && !up->port.membase) return; As you can see the test !up->port.mapbase is duplicated, which makes no sense. maybe a different test was intended here? also since membase is a pointer shouldn't the '&&' be replaced with '||'? thanks, Roel ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: questions regarding function autoconfig(); drivers/serial/8250.c 2007-11-23 22:42 questions regarding function autoconfig(); drivers/serial/8250.c Roel Kluin @ 2007-11-26 12:46 ` Uwe Kleine-König 2007-11-26 17:40 ` Roel Kluin 0 siblings, 1 reply; 3+ messages in thread From: Uwe Kleine-König @ 2007-11-26 12:46 UTC (permalink / raw) To: Roel Kluin; +Cc: linux-serial Roel Kluin wrote: > In drivers/serial/8250.c:995 it reads: > > if (!up->port.iobase && !up->port.mapbase && !up->port.membase) > return; > > As you can see the test !up->port.mapbase is duplicated, which makes no sense. > maybe a different test was intended here? Looking twice exposes that the second mapbase is actually a membase. So it looks right to me. Best regards Uwe -- Uwe Kleine-König http://www.google.com/search?q=30+hours+and+4+days+in+seconds - To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: questions regarding function autoconfig(); drivers/serial/8250.c 2007-11-26 12:46 ` Uwe Kleine-König @ 2007-11-26 17:40 ` Roel Kluin 0 siblings, 0 replies; 3+ messages in thread From: Roel Kluin @ 2007-11-26 17:40 UTC (permalink / raw) To: Uwe Kleine-König, Roel Kluin, linux-serial Uwe Kleine-König wrote: > Roel Kluin wrote: >> In drivers/serial/8250.c:995 it reads: >> >> if (!up->port.iobase && !up->port.mapbase && !up->port.membase) >> return; >> >> As you can see the test !up->port.mapbase is duplicated, which makes no sense. >> maybe a different test was intended here? > Looking twice exposes that the second mapbase is actually a membase. So > it looks right to me. > > Best regards > Uwe Thanks for the regards, clearly I need some glasses to improve mine. Roel - To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-11-26 17:40 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2007-11-23 22:42 questions regarding function autoconfig(); drivers/serial/8250.c Roel Kluin 2007-11-26 12:46 ` Uwe Kleine-König 2007-11-26 17:40 ` Roel Kluin
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.