From: Jeff Garzik <jgarzik@pobox.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: netdev@vger.kernel.org, auke-jan.h.kok@intel.com,
linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] e1000: Fix for 32 bits platforms with 64 bits resources
Date: Fri, 23 Nov 2007 21:52:03 -0500 [thread overview]
Message-ID: <474791D3.1090607@pobox.com> (raw)
In-Reply-To: <20071116073821.548CCDDDF4@ozlabs.org>
Benjamin Herrenschmidt wrote:
> The e1000 driver stores the content of the PCI resources into
> unsigned long's before ioremapping. This breaks on 32 bits
> platforms that support 64 bits MMIO resources such as ppc 44x.
>
> This fixes it by removing those temporary variables and passing
> directly the result of pci_resource_start/len to ioremap.
>
> The side effect is that I removed the assignments to the netdev
> fields mem_start, mem_end and base_addr, which are totally useless
> for PCI devices.
>
> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> --
>
> drivers/net/e1000/e1000_main.c | 18 +++++-------------
> 1 file changed, 5 insertions(+), 13 deletions(-)
Looks good to me. auke?
WARNING: multiple messages have this Message-ID (diff)
From: Jeff Garzik <jgarzik@pobox.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: auke-jan.h.kok@intel.com, netdev@vger.kernel.org,
linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] e1000: Fix for 32 bits platforms with 64 bits resources
Date: Fri, 23 Nov 2007 21:52:03 -0500 [thread overview]
Message-ID: <474791D3.1090607@pobox.com> (raw)
In-Reply-To: <20071116073821.548CCDDDF4@ozlabs.org>
Benjamin Herrenschmidt wrote:
> The e1000 driver stores the content of the PCI resources into
> unsigned long's before ioremapping. This breaks on 32 bits
> platforms that support 64 bits MMIO resources such as ppc 44x.
>
> This fixes it by removing those temporary variables and passing
> directly the result of pci_resource_start/len to ioremap.
>
> The side effect is that I removed the assignments to the netdev
> fields mem_start, mem_end and base_addr, which are totally useless
> for PCI devices.
>
> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> --
>
> drivers/net/e1000/e1000_main.c | 18 +++++-------------
> 1 file changed, 5 insertions(+), 13 deletions(-)
Looks good to me. auke?
next prev parent reply other threads:[~2007-11-24 2:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-16 7:37 [PATCH] e1000: Fix for 32 bits platforms with 64 bits resources Benjamin Herrenschmidt
2007-11-16 7:37 ` Benjamin Herrenschmidt
2007-11-24 2:52 ` Jeff Garzik [this message]
2007-11-24 2:52 ` Jeff Garzik
2007-11-26 23:15 ` Kok, Auke
2007-11-26 23:15 ` Kok, Auke
2007-11-28 18:47 ` Brandeburg, Jesse
2007-11-28 18:47 ` Brandeburg, Jesse
2007-11-28 19:52 ` Benjamin Herrenschmidt
2007-11-28 19:52 ` Benjamin Herrenschmidt
2008-02-06 12:13 ` Jeff Garzik
2008-02-06 12:13 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=474791D3.1090607@pobox.com \
--to=jgarzik@pobox.com \
--cc=auke-jan.h.kok@intel.com \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.