All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Stein <alexander.stein@ew.tq-group.com>
To: Shawn Guo <shawnguo@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	NXP Linux Team <linux-imx@nxp.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] arm64: dts: tqma8mpql: add PCIe support
Date: Tue, 01 Nov 2022 10:10:50 +0100	[thread overview]
Message-ID: <4754286.GXAFRqVoOG@steina-w> (raw)
In-Reply-To: <20221029035422.GL125525@dragon>

Hi Shawn,

thanks for your feedback.

Am Samstag, 29. Oktober 2022, 05:54:22 CET schrieb Shawn Guo:
> On Tue, Oct 18, 2022 at 10:53:29AM +0200, Alexander Stein wrote:
> > Add PCIe support on TQMa8MPxL module on MBa8MPxL mainboard.
> > 
> > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> > ---
> > This is based on next-20221018 where imp8mp PCIe support has been
> > merged.
> > 
> >  .../freescale/imx8mp-tqma8mpql-mba8mpxl.dts   | 42 ++++++++++++++++++-
> >  1 file changed, 41 insertions(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dts
> > b/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dts index
> > 7bf6f81e87b4..7a32379cd006 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dts
> > +++ b/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dts
> > @@ -8,6 +8,7 @@
> > 
> >  #include <dt-bindings/leds/common.h>
> >  #include <dt-bindings/net/ti-dp83867.h>
> > 
> > +#include <dt-bindings/phy/phy-imx8-pcie.h>
> > 
> >  #include <dt-bindings/pwm/pwm.h>
> >  #include "imx8mp-tqma8mpql.dtsi"
> > 
> > @@ -48,6 +49,12 @@ backlight_lvds: backlight {
> > 
> >  		status = "disabled";
> >  	
> >  	};
> > 
> > +	clk_xtal25: clk-xtal25 {
> > +		compatible = "fixed-clock";
> > +		#clock-cells = <0>;
> > +		clock-frequency = <25000000>;
> > +	};
> > +
> > 
> >  	gpio-keys {
> >  	
> >  		compatible = "gpio-keys";
> >  		pinctrl-names = "default";
> > 
> > @@ -340,9 +347,16 @@ &gpio4 {
> > 
> >  			  "", "", "", "",
> >  			  "", "", "", "",
> >  			  "", "", "DP_IRQ", "DSI_EN",
> > 
> > -			  "HDMI_OC#", "TEMP_EVENT#", "PCIE_CLK_OE#", "",
> > +			  "HDMI_OC#", "TEMP_EVENT#", "PCIE_REFCLK_OE#", 
"",
> > 
> >  			  "", "", "", "FAN_PWR",
> >  			  "RTC_EVENT#", "CODEC_RST#", "", "";
> > 
> > +
> > +	pcie_refclkreq-hog {
> 
> Hyphen is more recommended than underscore for node name.

Ah, yes. Will fix that. Thanks for spotting.

> > +		gpio-hog;
> > +		gpios = <22 0>;
> > +		output-high;
> > +		line-name = "PCIE_REFCLK_OE#";
> > +	};
> > 
> >  };
> >  
> >  &gpio5 {
> > 
> > @@ -377,6 +391,13 @@ at24c02_54: eeprom@54 {
> > 
> >  		pagesize = <16>;
> >  		vcc-supply = <&reg_vcc_3v3>;
> >  	
> >  	};
> > 
> > +
> > +	pcieclk: clk@6a {
> 
> Should be clock-controller@6a?

I will actually go with clock-generator@6a as shown in the bindings example.
The vendor actually names it a clock generator.

Thanks
Alexander

> Shawn
> 
> > +		compatible = "renesas,9fgv0241";
> > +		reg = <0x6a>;
> > +		clocks = <&clk_xtal25>;
> > +		#clock-cells = <1>;
> > +	};
> > 
> >  };
> >  
> >  &i2c4 {
> > 
> > @@ -407,6 +428,25 @@ &pcf85063 {
> > 
> >  	interrupts = <28 IRQ_TYPE_EDGE_FALLING>;
> >  
> >  };
> > 
> > +&pcie_phy {
> > +	fsl,clkreq-unsupported;
> > +	fsl,refclk-pad-mode = <IMX8_PCIE_REFCLK_PAD_INPUT>;
> > +	clocks = <&pcieclk 0>;
> > +	clock-names = "ref";
> > +	status = "okay";
> > +};
> > +
> > +&pcie {
> > +	clocks = <&clk IMX8MP_CLK_HSIO_ROOT>,
> > +		 <&clk IMX8MP_CLK_HSIO_AXI>,
> > +		 <&clk IMX8MP_CLK_PCIE_ROOT>;
> > +	clock-names = "pcie", "pcie_bus", "pcie_aux";
> > +	assigned-clocks = <&clk IMX8MP_CLK_PCIE_AUX>;
> > +	assigned-clock-rates = <10000000>;
> > +	assigned-clock-parents = <&clk IMX8MP_SYS_PLL2_50M>;
> > +	status = "okay";
> > +};
> > +
> > 
> >  &pwm2 {
> >  
> >  	pinctrl-names = "default";
> >  	pinctrl-0 = <&pinctrl_pwm2>;





_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Alexander Stein <alexander.stein@ew.tq-group.com>
To: Shawn Guo <shawnguo@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	NXP Linux Team <linux-imx@nxp.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] arm64: dts: tqma8mpql: add PCIe support
Date: Tue, 01 Nov 2022 10:10:50 +0100	[thread overview]
Message-ID: <4754286.GXAFRqVoOG@steina-w> (raw)
In-Reply-To: <20221029035422.GL125525@dragon>

Hi Shawn,

thanks for your feedback.

Am Samstag, 29. Oktober 2022, 05:54:22 CET schrieb Shawn Guo:
> On Tue, Oct 18, 2022 at 10:53:29AM +0200, Alexander Stein wrote:
> > Add PCIe support on TQMa8MPxL module on MBa8MPxL mainboard.
> > 
> > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> > ---
> > This is based on next-20221018 where imp8mp PCIe support has been
> > merged.
> > 
> >  .../freescale/imx8mp-tqma8mpql-mba8mpxl.dts   | 42 ++++++++++++++++++-
> >  1 file changed, 41 insertions(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dts
> > b/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dts index
> > 7bf6f81e87b4..7a32379cd006 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dts
> > +++ b/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dts
> > @@ -8,6 +8,7 @@
> > 
> >  #include <dt-bindings/leds/common.h>
> >  #include <dt-bindings/net/ti-dp83867.h>
> > 
> > +#include <dt-bindings/phy/phy-imx8-pcie.h>
> > 
> >  #include <dt-bindings/pwm/pwm.h>
> >  #include "imx8mp-tqma8mpql.dtsi"
> > 
> > @@ -48,6 +49,12 @@ backlight_lvds: backlight {
> > 
> >  		status = "disabled";
> >  	
> >  	};
> > 
> > +	clk_xtal25: clk-xtal25 {
> > +		compatible = "fixed-clock";
> > +		#clock-cells = <0>;
> > +		clock-frequency = <25000000>;
> > +	};
> > +
> > 
> >  	gpio-keys {
> >  	
> >  		compatible = "gpio-keys";
> >  		pinctrl-names = "default";
> > 
> > @@ -340,9 +347,16 @@ &gpio4 {
> > 
> >  			  "", "", "", "",
> >  			  "", "", "", "",
> >  			  "", "", "DP_IRQ", "DSI_EN",
> > 
> > -			  "HDMI_OC#", "TEMP_EVENT#", "PCIE_CLK_OE#", "",
> > +			  "HDMI_OC#", "TEMP_EVENT#", "PCIE_REFCLK_OE#", 
"",
> > 
> >  			  "", "", "", "FAN_PWR",
> >  			  "RTC_EVENT#", "CODEC_RST#", "", "";
> > 
> > +
> > +	pcie_refclkreq-hog {
> 
> Hyphen is more recommended than underscore for node name.

Ah, yes. Will fix that. Thanks for spotting.

> > +		gpio-hog;
> > +		gpios = <22 0>;
> > +		output-high;
> > +		line-name = "PCIE_REFCLK_OE#";
> > +	};
> > 
> >  };
> >  
> >  &gpio5 {
> > 
> > @@ -377,6 +391,13 @@ at24c02_54: eeprom@54 {
> > 
> >  		pagesize = <16>;
> >  		vcc-supply = <&reg_vcc_3v3>;
> >  	
> >  	};
> > 
> > +
> > +	pcieclk: clk@6a {
> 
> Should be clock-controller@6a?

I will actually go with clock-generator@6a as shown in the bindings example.
The vendor actually names it a clock generator.

Thanks
Alexander

> Shawn
> 
> > +		compatible = "renesas,9fgv0241";
> > +		reg = <0x6a>;
> > +		clocks = <&clk_xtal25>;
> > +		#clock-cells = <1>;
> > +	};
> > 
> >  };
> >  
> >  &i2c4 {
> > 
> > @@ -407,6 +428,25 @@ &pcf85063 {
> > 
> >  	interrupts = <28 IRQ_TYPE_EDGE_FALLING>;
> >  
> >  };
> > 
> > +&pcie_phy {
> > +	fsl,clkreq-unsupported;
> > +	fsl,refclk-pad-mode = <IMX8_PCIE_REFCLK_PAD_INPUT>;
> > +	clocks = <&pcieclk 0>;
> > +	clock-names = "ref";
> > +	status = "okay";
> > +};
> > +
> > +&pcie {
> > +	clocks = <&clk IMX8MP_CLK_HSIO_ROOT>,
> > +		 <&clk IMX8MP_CLK_HSIO_AXI>,
> > +		 <&clk IMX8MP_CLK_PCIE_ROOT>;
> > +	clock-names = "pcie", "pcie_bus", "pcie_aux";
> > +	assigned-clocks = <&clk IMX8MP_CLK_PCIE_AUX>;
> > +	assigned-clock-rates = <10000000>;
> > +	assigned-clock-parents = <&clk IMX8MP_SYS_PLL2_50M>;
> > +	status = "okay";
> > +};
> > +
> > 
> >  &pwm2 {
> >  
> >  	pinctrl-names = "default";
> >  	pinctrl-0 = <&pinctrl_pwm2>;





  reply	other threads:[~2022-11-01  9:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-18  8:53 [PATCH 1/2] arm64: dts: tqma8mpql: add PCIe support Alexander Stein
2022-10-18  8:53 ` Alexander Stein
2022-10-18  8:53 ` [PATCH 2/2] arm64: defconfig: Add Renesas 9-series PCIe clock generator Alexander Stein
2022-10-18  8:53   ` Alexander Stein
2022-10-29  3:54 ` [PATCH 1/2] arm64: dts: tqma8mpql: add PCIe support Shawn Guo
2022-10-29  3:54   ` Shawn Guo
2022-11-01  9:10   ` Alexander Stein [this message]
2022-11-01  9:10     ` Alexander Stein

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4754286.GXAFRqVoOG@steina-w \
    --to=alexander.stein@ew.tq-group.com \
    --cc=catalin.marinas@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.