Man page fix for matchpatchcon

Man page fix for matchpatchcon

[Daniel J Walsh]

[-- Attachment #1: Type: text/plain, Size: 299 bytes --]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

iD8DBQFHWDs1rlYvE4MpobMRAmDBAKC3EnBRz81RxtgLKcMSHnUvMqNJkwCcCyx+
QgfQjemToY0sD9lksoYX/wo=
=7auR
-----END PGP SIGNATURE-----

[-- Attachment #2: diff --]
[-- Type: text/plain, Size: 932 bytes --]

diff --exclude-from=exclude -N -u -r nsalibselinux/man/man8/matchpathcon.8 libselinux-2.0.45/man/man8/matchpathcon.8
--- nsalibselinux/man/man8/matchpathcon.8	2007-08-03 16:02:56.000000000 -0400
+++ libselinux-2.0.45/man/man8/matchpathcon.8	2007-12-06 11:22:40.000000000 -0500
@@ -6,7 +6,12 @@
 .B matchpathcon [-V] [-N] [-n] [-f file_contexts_file ] [-p prefix ] filepath...
 .SH "DESCRIPTION"
 .B matchpathcon
-Prints the file path and the default security context associated with it.
+Queries the system and prints the default security context associated with the filepath.
+
+Note: Identical paths can have different security contexts, depending on the file type. (regular file, directory, link file, char file ...)
+
+matchpathcon will check the system default context using the file type if the file exists.  If the file does not exist, it will get the context of a regular file.
+
 .SH OPTIONS
 .B \-n
 Do not display path.


[-- Attachment #3: diff.sig --]
[-- Type: application/octet-stream, Size: 65 bytes --]

RE: Man page fix for matchpatchcon

[Todd Miller]

Comments inline, hopefully the mail client won't munge things too much.

 - todd

diff --exclude-from=exclude -N -u -r
nsalibselinux/man/man8/matchpathcon.8
libselinux-2.0.45/man/man8/matchpathcon.8
--- nsalibselinux/man/man8/matchpathcon.8	2007-08-03
16:02:56.000000000 -0400
+++ libselinux-2.0.45/man/man8/matchpathcon.8	2007-12-06
11:22:40.000000000 -0500
@@ -6,7 +6,12 @@
 .B matchpathcon [-V] [-N] [-n] [-f file_contexts_file ] [-p prefix ]
filepath...
 .SH "DESCRIPTION"
 .B matchpathcon
-Prints the file path and the default security context associated with
it.
+Queries the system and prints the default security context associated
with the filepath.

This should be a lower case 'q' since it is not the start of the
sentence.

+
+Note: Identical paths can have different security contexts, depending
on the file type. (regular file, directory, link file, char file ...)
+
+matchpathcon will check the system default context using the file type
if the file exists.  If 
the file does not exist, it will get the context of a regular file.

Should probably use ".B matchpathcon" here.

+
 .SH OPTIONS
 .B \-n
 Do not display path.


--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.

RE: Man page fix for matchpatchcon

[Stephen Smalley]

On Thu, 2007-12-06 at 16:16 -0500, Todd Miller wrote:
> Comments inline, hopefully the mail client won't munge things too much.
> 
>  - todd
> 
> diff --exclude-from=exclude -N -u -r
> nsalibselinux/man/man8/matchpathcon.8
> libselinux-2.0.45/man/man8/matchpathcon.8
> --- nsalibselinux/man/man8/matchpathcon.8	2007-08-03
> 16:02:56.000000000 -0400
> +++ libselinux-2.0.45/man/man8/matchpathcon.8	2007-12-06
> 11:22:40.000000000 -0500
> @@ -6,7 +6,12 @@
>  .B matchpathcon [-V] [-N] [-n] [-f file_contexts_file ] [-p prefix ]
> filepath...
>  .SH "DESCRIPTION"
>  .B matchpathcon
> -Prints the file path and the default security context associated with
> it.
> +Queries the system and prints the default security context associated
> with the filepath.
> 
> This should be a lower case 'q' since it is not the start of the
> sentence.
> 
> +
> +Note: Identical paths can have different security contexts, depending
> on the file type. (regular file, directory, link file, char file ...)
> +
> +matchpathcon will check the system default context using the file type
> if the file exists.  If 
> the file does not exist, it will get the context of a regular file.

Also, this last part wasn't right - if the file doesn't exist, then
matchpathcon passes a 0 mode to matchpathcon(3), which in turn does no
file mode/type matching at all in that case (so any entry will match).

Applied those fixes and committed.

> 
> Should probably use ".B matchpathcon" here.
> 
> +
>  .SH OPTIONS
>  .B \-n
>  Do not display path.
-- 
Stephen Smalley
National Security Agency


--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.