From: Christian Ehrhardt <ehrhardt@linux.vnet.ibm.com>
To: "kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org"
<kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
Cc: kvm-ppc-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
Jerone Young <jyoung5-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>,
Hollis Blanchard
<hollisb-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
Subject: [kvm-ppc-devel] [PATCH] [0/1] simplify kvm-userspace to qemu-kvm
Date: Fri, 07 Dec 2007 11:38:14 +0000 [thread overview]
Message-ID: <475930A6.60301@linux.vnet.ibm.com> (raw)
In-Reply-To: <4756BB14.1080708-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
Well no response might mean that there is nothing to be said against this
simplification ;-)
Because of that I completed the patch (main.c as well) and corrected some
whitespace issues I had before.
Christian Ehrhardt wrote:
> Background:
> In our ppc code for the demo we only needed a call to
> cpu_physical_memory_rw to handle all kind of mmio we needed. Looking at
> all the callback pointers for read/write mmio in kvm_callbacks I
> wondered if this can be simplified with cpu_physical_memory_rw for x86
> too. So I tested it today and it works fine on with kvm-svm on my opteron.
> The only code that did not just redirect to another function was a
> workaround for a Redhat 7.1 issue, so I merged it in the central call
> making it easier to find and maintain (was split before) anyway.
> If everyone agrees with it I will create a new patch also affecting the
> other implementations of this interface e.g. user/main.c and a rebased
> version of this one.
> But maybe there was a reason to do it that split way with all the
> callback pointers that was not obvious to me, so please comment.
> [...]
--
Grüsse / regards,
Christian Ehrhardt
IBM Linux Technology Center, Open Virtualization
+49 7031/16-3385
Ehrhardt@linux.vnet.ibm.com
Ehrhardt@de.ibm.com
IBM Deutschland Entwicklung GmbH
Vorsitzender des Aufsichtsrats: Johann Weihen
Geschäftsführung: Herbert Kircher
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294
-------------------------------------------------------------------------
SF.Net email is sponsored by:
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
_______________________________________________
kvm-ppc-devel mailing list
kvm-ppc-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-ppc-devel
WARNING: multiple messages have this Message-ID (diff)
From: Christian Ehrhardt <ehrhardt-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
To: "kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org"
<kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
Cc: kvm-ppc-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
Jerone Young <jyoung5-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>,
Hollis Blanchard
<hollisb-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
Subject: [PATCH] [0/1] simplify kvm-userspace to qemu-kvm callback structure
Date: Fri, 07 Dec 2007 12:38:14 +0100 [thread overview]
Message-ID: <475930A6.60301@linux.vnet.ibm.com> (raw)
In-Reply-To: <4756BB14.1080708-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
Well no response might mean that there is nothing to be said against this
simplification ;-)
Because of that I completed the patch (main.c as well) and corrected some
whitespace issues I had before.
Christian Ehrhardt wrote:
> Background:
> In our ppc code for the demo we only needed a call to
> cpu_physical_memory_rw to handle all kind of mmio we needed. Looking at
> all the callback pointers for read/write mmio in kvm_callbacks I
> wondered if this can be simplified with cpu_physical_memory_rw for x86
> too. So I tested it today and it works fine on with kvm-svm on my opteron.
> The only code that did not just redirect to another function was a
> workaround for a Redhat 7.1 issue, so I merged it in the central call
> making it easier to find and maintain (was split before) anyway.
> If everyone agrees with it I will create a new patch also affecting the
> other implementations of this interface e.g. user/main.c and a rebased
> version of this one.
> But maybe there was a reason to do it that split way with all the
> callback pointers that was not obvious to me, so please comment.
> [...]
--
Grüsse / regards,
Christian Ehrhardt
IBM Linux Technology Center, Open Virtualization
+49 7031/16-3385
Ehrhardt-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org
Ehrhardt-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org
IBM Deutschland Entwicklung GmbH
Vorsitzender des Aufsichtsrats: Johann Weihen
Geschäftsführung: Herbert Kircher
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294
-------------------------------------------------------------------------
SF.Net email is sponsored by:
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
next prev parent reply other threads:[~2007-12-07 11:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-05 14:52 [kvm-ppc-devel] [PATCH] RFC: simplify kvm-userspace to qemu-kvm Christian Ehrhardt
2007-12-05 14:52 ` [PATCH] RFC: simplify kvm-userspace to qemu-kvm callback structure Christian Ehrhardt
[not found] ` <4756BB14.1080708-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2007-12-06 14:50 ` [kvm-ppc-devel] [kvm-devel] [PATCH] RFC: simplify kvm-userspace Avi Kivity
2007-12-06 14:50 ` [PATCH] RFC: simplify kvm-userspace to qemu-kvm callback structure Avi Kivity
[not found] ` <47580C1B.4090708-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-12-11 13:01 ` [kvm-ppc-devel] [kvm-devel] [PATCH] RFC: simplify kvm-userspace Christian Ehrhardt
2007-12-11 13:01 ` [PATCH] RFC: simplify kvm-userspace to qemu-kvm callback structure Christian Ehrhardt
2007-12-07 11:38 ` Christian Ehrhardt [this message]
2007-12-07 11:38 ` [PATCH] [0/1] " Christian Ehrhardt
[not found] ` <475930A6.60301-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2007-12-07 11:40 ` [kvm-ppc-devel] [kvm-devel] [PATCH] [0/1] simplify Avi Kivity
2007-12-07 11:40 ` [PATCH] [0/1] simplify kvm-userspace to qemu-kvm callback structure Avi Kivity
2007-12-07 11:38 ` [kvm-ppc-devel] [PATCH] [1/1] simplify kvm-userspace to qemu-kvm Christian Ehrhardt
2007-12-07 11:38 ` [PATCH] [1/1] simplify kvm-userspace to qemu-kvm callback structure Christian Ehrhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=475930A6.60301@linux.vnet.ibm.com \
--to=ehrhardt@linux.vnet.ibm.com \
--cc=hollisb-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
--cc=jyoung5-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
--cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=kvm-ppc-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.