All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony-rdkfGonbjUSkNkDKm+mE6A@public.gmane.org>
To: Ryan Harper <ryanh-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
	qemu-devel-qX2TKyscuCcdnm+yROfE0A@public.gmane.org
Subject: Re: [Qemu-devel] Re: [PATCH 1 of 3] export SMBIOS/DMI tables to PC machines
Date: Fri, 07 Dec 2007 15:24:38 -0600	[thread overview]
Message-ID: <4759BA16.2020007@codemonkey.ws> (raw)
In-Reply-To: <20071207211318.GG23913-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>

Ryan Harper wrote:
> * Anthony Liguori <anthony-rdkfGonbjUSkNkDKm+mE6A@public.gmane.org> [2007-12-07 15:07]:
>   
>> Ryan Harper wrote:
>>     
>>> * Anthony Liguori <anthony-rdkfGonbjUSkNkDKm+mE6A@public.gmane.org> [2007-12-07 14:49]:
>>>  
>>>       
>>>>> +
>>>>> +CPUState *first_cpu;
>>>>>
>>>>>      
>>>>>           
>>>> This should probably be static.
>>>>    
>>>>         
>>> doh, should be extern actually since it's defined elsewhere.
>>>  
>>>       
>> Perhaps you want cpu_single_env instead of first_cpu?
>>     
>
> I wasn't quite sure given the comments surrounding its declaration:
>
> from exec.c:
>
> CPUState *first_cpu;
> /* current CPU in the current thread. It is only valid inside
>       cpu_exec() */
> CPUState *cpu_single_env;
>   

Yeah, I guess since you build this at init time, first_cpu is more 
appropriate.

Regards,

Anthony Liguori



-------------------------------------------------------------------------
SF.Net email is sponsored by:
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php

WARNING: multiple messages have this Message-ID (diff)
From: Anthony Liguori <anthony@codemonkey.ws>
To: Ryan Harper <ryanh@us.ibm.com>
Cc: kvm-devel@lists.sourceforge.net, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Re: [kvm-devel] [PATCH 1 of 3] export SMBIOS/DMI tables to PC machines
Date: Fri, 07 Dec 2007 15:24:38 -0600	[thread overview]
Message-ID: <4759BA16.2020007@codemonkey.ws> (raw)
In-Reply-To: <20071207211318.GG23913@us.ibm.com>

Ryan Harper wrote:
> * Anthony Liguori <anthony@codemonkey.ws> [2007-12-07 15:07]:
>   
>> Ryan Harper wrote:
>>     
>>> * Anthony Liguori <anthony@codemonkey.ws> [2007-12-07 14:49]:
>>>  
>>>       
>>>>> +
>>>>> +CPUState *first_cpu;
>>>>>
>>>>>      
>>>>>           
>>>> This should probably be static.
>>>>    
>>>>         
>>> doh, should be extern actually since it's defined elsewhere.
>>>  
>>>       
>> Perhaps you want cpu_single_env instead of first_cpu?
>>     
>
> I wasn't quite sure given the comments surrounding its declaration:
>
> from exec.c:
>
> CPUState *first_cpu;
> /* current CPU in the current thread. It is only valid inside
>       cpu_exec() */
> CPUState *cpu_single_env;
>   

Yeah, I guess since you build this at init time, first_cpu is more 
appropriate.

Regards,

Anthony Liguori

  parent reply	other threads:[~2007-12-07 21:24 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-07 20:36 [PATCH 0 of 3] Add SMBIOS/DMI table generation to PC machine Ryan Harper
     [not found] ` <patchbomb.1197059814-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2007-12-07 20:36   ` [PATCH 1 of 3] export SMBIOS/DMI tables to PC machines Ryan Harper
     [not found]     ` <37bf559ffcf74bfe62ec.1197059815-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2007-12-07 20:48       ` Anthony Liguori
2007-12-07 20:48         ` [Qemu-devel] Re: [kvm-devel] " Anthony Liguori
     [not found]         ` <4759B1A9.5080302-rdkfGonbjUSkNkDKm+mE6A@public.gmane.org>
2007-12-07 20:52           ` Ryan Harper
2007-12-07 20:52             ` [Qemu-devel] Re: [kvm-devel] " Ryan Harper
     [not found]             ` <20071207205250.GF23913-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2007-12-07 21:04               ` Anthony Liguori
2007-12-07 21:04                 ` [Qemu-devel] Re: [kvm-devel] " Anthony Liguori
     [not found]                 ` <4759B559.1070405-rdkfGonbjUSkNkDKm+mE6A@public.gmane.org>
2007-12-07 21:13                   ` [Qemu-devel] " Ryan Harper
2007-12-07 21:13                     ` [Qemu-devel] Re: [kvm-devel] " Ryan Harper
     [not found]                     ` <20071207211318.GG23913-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2007-12-07 21:24                       ` Anthony Liguori [this message]
2007-12-07 21:24                         ` Anthony Liguori
2007-12-07 20:36   ` [PATCH 2 of 3] Optionally link against libuuid if present Ryan Harper
2007-12-07 20:36   ` [PATCH 3 of 3] Add -uuid command line flag Ryan Harper
     [not found]     ` <5fe703a5a7bde701686f.1197059817-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2007-12-07 20:52       ` Anthony Liguori
2007-12-07 20:52         ` [Qemu-devel] Re: [kvm-devel] " Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4759BA16.2020007@codemonkey.ws \
    --to=anthony-rdkfgonbjusknkdkm+me6a@public.gmane.org \
    --cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=qemu-devel-qX2TKyscuCcdnm+yROfE0A@public.gmane.org \
    --cc=ryanh-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.