From: Wolfgang Grandegger <wg@domain.hid>
To: Thomas Wiedemann <Thomas.Wiedemann@domain.hid>
Cc: xenomai-core <xenomai@xenomai.org>
Subject: Re: [Xenomai-core] Antwort: Xenomai v2.4.0: CONFIG_XENO_OPT_SHIRQ_LEVEL vs. CONFIG_XENO_OPT_SHIRQ
Date: Mon, 10 Dec 2007 21:37:43 +0100 [thread overview]
Message-ID: <475DA397.6000408@domain.hid> (raw)
In-Reply-To: <OFD2B0EC2A.B4C937F8-ONC12573AD.0036F9DB-C12573AD.00370BC4@domain.hid>
Thomas Wiedemann wrote:
> Hi,
>
> we had a problem compiling the CAN-Driver for the last release candidate
> when
> shared interrupts had been enabled, because of the re-named option
> "CONFIG_XENO_OPT_SHIRQ_LEVEL.". After a quick look, version 2.4.0 still
> doesn't fix this. A patch is included (for ksrc/drivers/can).
Ah, thanks for reporting. I'm going to remove these #ifdefs a.s.a.p.
It's sufficient to print an appropriate error messsage in case interrupt
registration fails with -EBUSY.
Wolfgang.
> ------------------------------------------------------------------------
>
> diff -urN sja1000.orig/rtcan_ems_pci.c sja1000/rtcan_ems_pci.c
> --- sja1000.orig/rtcan_ems_pci.c 2007-09-16 19:20:45.000000000 +0200
> +++ sja1000/rtcan_ems_pci.c 2007-12-10 10:14:58.000000000 +0100
> @@ -272,7 +272,7 @@
> if ((err = rtcan_ems_pci_add_chan(pdev, EMS_PCI_MASTER,
> &master_dev)))
> goto failure_cleanup;
> -#ifdef CONFIG_XENO_OPT_SHIRQ_LEVEL
> +#ifdef CONFIG_XENO_OPT_SHIRQ
> if ((err = rtcan_ems_pci_add_chan(pdev, EMS_PCI_SLAVE,
> &master_dev)))
> goto failure_cleanup;
> diff -urN sja1000.orig/rtcan_ixxat_pci.c sja1000/rtcan_ixxat_pci.c
> --- sja1000.orig/rtcan_ixxat_pci.c 2007-09-16 19:20:45.000000000 +0200
> +++ sja1000/rtcan_ixxat_pci.c 2007-12-10 10:14:54.000000000 +0100
> @@ -254,7 +254,7 @@
> goto failure_iounmap;
>
> if (channel != CHANNEL_SINGLE) {
> -#ifdef CONFIG_XENO_OPT_SHIRQ_LEVEL
> +#ifdef CONFIG_XENO_OPT_SHIRQ
> channel = CHANNEL_SLAVE;
> if ((ret = rtcan_ixxat_pci_add_chan(pdev, channel,
> &master_dev, conf_addr,
> diff -urN sja1000.orig/rtcan_peak_pci.c sja1000/rtcan_peak_pci.c
> --- sja1000.orig/rtcan_peak_pci.c 2007-09-16 19:20:45.000000000 +0200
> +++ sja1000/rtcan_peak_pci.c 2007-12-10 10:14:51.000000000 +0100
> @@ -292,7 +292,7 @@
> if ((ret = rtcan_peak_pci_add_chan(pdev, CHANNEL_MASTER,
> &master_dev)))
> goto failure_cleanup;
> -#ifdef CONFIG_XENO_OPT_SHIRQ_LEVEL
> +#ifdef CONFIG_XENO_OPT_SHIRQ
> if ((ret = rtcan_peak_pci_add_chan(pdev, CHANNEL_SLAVE,
> &master_dev)))
> goto failure_cleanup;
>
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> Xenomai-core mailing list
> Xenomai-core@domain.hid
> https://mail.gna.org/listinfo/xenomai-core
next prev parent reply other threads:[~2007-12-10 20:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-10 10:01 [Xenomai-core] Antwort: Xenomai v2.4.0: CONFIG_XENO_OPT_SHIRQ_LEVEL vs. CONFIG_XENO_OPT_SHIRQ Thomas Wiedemann
2007-12-10 20:37 ` Wolfgang Grandegger [this message]
2007-12-17 11:37 ` Wolfgang Grandegger
2007-12-22 18:58 ` Philippe Gerum
2007-12-22 20:52 ` Wolfgang Grandegger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=475DA397.6000408@domain.hid \
--to=wg@domain.hid \
--cc=Thomas.Wiedemann@domain.hid \
--cc=xenomai@xenomai.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.