From: Wolfgang Grandegger <wg@domain.hid>
To: rpm@xenomai.org
Cc: Thomas Wiedemann <Thomas.Wiedemann@domain.hid>,
xenomai-core <xenomai@xenomai.org>
Subject: Re: [Xenomai-core] Antwort: Xenomai v2.4.0: CONFIG_XENO_OPT_SHIRQ_LEVEL vs. CONFIG_XENO_OPT_SHIRQ
Date: Sat, 22 Dec 2007 21:52:36 +0100 [thread overview]
Message-ID: <476D7914.3010703@domain.hid> (raw)
In-Reply-To: <476D5E66.5050902@domain.hid>
Philippe Gerum wrote:
> Wolfgang Grandegger wrote:
>> Wolfgang Grandegger wrote:
>>> Thomas Wiedemann wrote:
>>>> Hi,
>>>>
>>>> we had a problem compiling the CAN-Driver for the last release candidate
>>>> when
>>>> shared interrupts had been enabled, because of the re-named option
>>>> "CONFIG_XENO_OPT_SHIRQ_LEVEL.". After a quick look, version 2.4.0 still
>>>> doesn't fix this. A patch is included (for ksrc/drivers/can).
>>> Ah, thanks for reporting. I'm going to remove these #ifdefs a.s.a.p.
>>> It's sufficient to print an appropriate error messsage in case interrupt
>>> registration fails with -EBUSY.
>> The attached patch fixes this issue. Here is the ChangeLog entry:
>>
>> 2007-12-17 Wolfgang Grandegger <wg@domain.hid>
>>
>> * ksrc/drivers/can/sja1000/{rtcan_sja1000.c, rtcan_*_pci.c}: Remove
>> CONFIG_XENO_OPT_SHIRQ* ifdefs to fix build problems with recent
>> versions of Xenomai. If rtdm_irq_request() now fails with -EBUSY, an
>> error message reminds the user to check for shared interrupt support.
>>
>> * ksrc/drivers/can/rtcan_dev.c (rtcan_dev_unregister): unregister
>> devices properly in case refcounts are disabled.
>>
>> If there are no objections, I'm going to apply this patch to Xenomai
>> v2.3.x, v2.4.x and the trunk.
>>
>
> Please merge. TIA,
Done.
Wolfgang.
prev parent reply other threads:[~2007-12-22 20:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-10 10:01 [Xenomai-core] Antwort: Xenomai v2.4.0: CONFIG_XENO_OPT_SHIRQ_LEVEL vs. CONFIG_XENO_OPT_SHIRQ Thomas Wiedemann
2007-12-10 20:37 ` Wolfgang Grandegger
2007-12-17 11:37 ` Wolfgang Grandegger
2007-12-22 18:58 ` Philippe Gerum
2007-12-22 20:52 ` Wolfgang Grandegger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=476D7914.3010703@domain.hid \
--to=wg@domain.hid \
--cc=Thomas.Wiedemann@domain.hid \
--cc=rpm@xenomai.org \
--cc=xenomai@xenomai.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.