* [PATCH] parport : "dev->timeslice" is an unsigned long, not an int
@ 2007-12-11 19:49 Eric Dumazet
0 siblings, 0 replies; only message in thread
From: Eric Dumazet @ 2007-12-11 19:49 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux kernel
[-- Attachment #1: Type: text/plain, Size: 277 bytes --]
While auditing proc_doulongvec_ms_jiffies_minmax() usage in kernel, I
found a bug
in drivers/parport/procfs.c, incorrectly using sizeof(int) instead of
sizeof(unsigned long)
Only 64bit arches are affected by this old bug.
Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>
[-- Attachment #2: parport.patch --]
[-- Type: text/plain, Size: 460 bytes --]
diff --git a/drivers/parport/procfs.c b/drivers/parport/procfs.c
index ed82e41..d950fc3 100644
--- a/drivers/parport/procfs.c
+++ b/drivers/parport/procfs.c
@@ -384,7 +384,7 @@ parport_device_sysctl_template = {
{
.procname = "timeslice",
.data = NULL,
- .maxlen = sizeof(int),
+ .maxlen = sizeof(unsigned long),
.mode = 0644,
.proc_handler = &proc_doulongvec_ms_jiffies_minmax,
.extra1 = (void*) &parport_min_timeslice_value,
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2007-12-11 19:49 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-12-11 19:49 [PATCH] parport : "dev->timeslice" is an unsigned long, not an int Eric Dumazet
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.