From: Mark Lord <liml@rtr.ca>
To: Matthew Wilcox <matthew@wil.cx>
Cc: Mel Gorman <mel@csn.ul.ie>,
Andrew Morton <akpm@linux-foundation.org>,
James.Bottomley@HansenPartnership.com, jens.axboe@oracle.com,
lkml@rtr.ca, linux-ide@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH] fix page_alloc for larger I/O segments (improved)
Date: Fri, 14 Dec 2007 13:30:14 -0500 [thread overview]
Message-ID: <4762CBB6.5030301@rtr.ca> (raw)
In-Reply-To: <20071214181339.GW26334@parisc-linux.org>
Matthew Wilcox wrote:
> On Fri, Dec 14, 2007 at 05:42:37PM +0000, Mel Gorman wrote:
>> Regrettably this interferes with anti-fragmentation because the "next" page
>> on the list on return from rmqueue_bulk is not guaranteed to be of the right
>> mobility type. I fixed it as an additional patch but it adds additional cost
>> that should not be necessary and it's visible in microbenchmark results on
>> at least one machine.
>
> Is this patch to be preferred to the one Andrew Morton posted to do
> list_for_each_entry_reverse?
..
This patch replaces my earlier patch that Andrew has:
- list_add(&page->lru, list);
+ list_add_tail(&page->lru, list);
Which, in turn, replaced the even-earlier list_for_each_entry_reverse patch.
-ml
WARNING: multiple messages have this Message-ID (diff)
From: Mark Lord <liml@rtr.ca>
To: Matthew Wilcox <matthew@wil.cx>
Cc: Mel Gorman <mel@csn.ul.ie>,
Andrew Morton <akpm@linux-foundation.org>,
James.Bottomley@HansenPartnership.com, jens.axboe@oracle.com,
lkml@rtr.ca, linux-ide@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH] fix page_alloc for larger I/O segments (improved)
Date: Fri, 14 Dec 2007 13:30:14 -0500 [thread overview]
Message-ID: <4762CBB6.5030301@rtr.ca> (raw)
In-Reply-To: <20071214181339.GW26334@parisc-linux.org>
Matthew Wilcox wrote:
> On Fri, Dec 14, 2007 at 05:42:37PM +0000, Mel Gorman wrote:
>> Regrettably this interferes with anti-fragmentation because the "next" page
>> on the list on return from rmqueue_bulk is not guaranteed to be of the right
>> mobility type. I fixed it as an additional patch but it adds additional cost
>> that should not be necessary and it's visible in microbenchmark results on
>> at least one machine.
>
> Is this patch to be preferred to the one Andrew Morton posted to do
> list_for_each_entry_reverse?
..
This patch replaces my earlier patch that Andrew has:
- list_add(&page->lru, list);
+ list_add_tail(&page->lru, list);
Which, in turn, replaced the even-earlier list_for_each_entry_reverse patch.
-ml
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-12-14 18:30 UTC|newest]
Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-13 18:36 QUEUE_FLAG_CLUSTER: not working in 2.6.24 ? Mark Lord
2007-12-13 18:37 ` Mark Lord
2007-12-13 18:42 ` Matthew Wilcox
2007-12-13 18:46 ` James Bottomley
2007-12-13 18:48 ` Mark Lord
2007-12-13 18:53 ` Matthew Wilcox
2007-12-13 19:03 ` Mark Lord
2007-12-13 19:26 ` Jens Axboe
2007-12-13 19:30 ` Mark Lord
2007-12-13 19:32 ` Mark Lord
2007-12-13 19:39 ` Jens Axboe
2007-12-13 19:42 ` Mark Lord
2007-12-13 19:53 ` Jens Axboe
2007-12-13 19:59 ` Mark Lord
2007-12-13 20:05 ` Jens Axboe
2007-12-13 20:02 ` Jens Axboe
2007-12-13 20:06 ` Mark Lord
2007-12-13 20:09 ` Jens Axboe
2007-12-13 20:14 ` Mark Lord
2007-12-13 20:18 ` Mark Lord
2007-12-13 20:21 ` Jens Axboe
2007-12-13 22:02 ` Andrew Morton
2007-12-13 22:02 ` Andrew Morton
2007-12-13 22:15 ` James Bottomley
2007-12-13 22:15 ` James Bottomley
2007-12-13 22:29 ` Andrew Morton
2007-12-13 22:29 ` Andrew Morton
2007-12-13 22:33 ` Mark Lord
2007-12-13 22:33 ` Mark Lord
2007-12-13 23:13 ` Mark Lord
2007-12-13 23:13 ` Mark Lord
2007-12-14 0:05 ` Mark Lord
2007-12-14 0:05 ` Mark Lord
2007-12-14 0:30 ` Mark Lord
2007-12-14 0:30 ` Mark Lord
2007-12-14 0:37 ` Andrew Morton
2007-12-14 0:37 ` Andrew Morton
2007-12-14 0:42 ` Mark Lord
2007-12-14 0:42 ` Mark Lord
2007-12-14 0:46 ` [PATCH] fix page_alloc for larger I/O segments (improved) Mark Lord
2007-12-14 0:46 ` Mark Lord
2007-12-14 0:57 ` James Bottomley
2007-12-14 0:57 ` James Bottomley
2007-12-14 1:11 ` Andrew Morton
2007-12-14 1:11 ` Andrew Morton
2007-12-14 2:23 ` Mark Lord
2007-12-14 2:23 ` Mark Lord
2007-12-14 2:23 ` Mark Lord
2007-12-14 17:42 ` Mel Gorman
2007-12-14 17:42 ` Mel Gorman
2007-12-14 18:07 ` Mark Lord
2007-12-14 18:07 ` Mark Lord
2007-12-16 21:56 ` Mel Gorman
2007-12-16 21:56 ` Mel Gorman
2007-12-14 18:13 ` Matthew Wilcox
2007-12-14 18:13 ` Matthew Wilcox
2007-12-14 18:30 ` Mark Lord [this message]
2007-12-14 18:30 ` Mark Lord
2007-12-20 22:37 ` Matthew Wilcox
2007-12-20 22:37 ` Matthew Wilcox
2007-12-14 0:47 ` QUEUE_FLAG_CLUSTER: not working in 2.6.24 ? Mark Lord
2007-12-14 0:47 ` Mark Lord
2007-12-14 11:50 ` Mel Gorman
2007-12-14 11:50 ` Mel Gorman
2007-12-14 13:57 ` Mark Lord
2007-12-14 13:57 ` Mark Lord
2007-12-14 0:40 ` [PATCH] fix page_alloc for larger I/O segments Mark Lord
2007-12-14 0:40 ` Mark Lord
2007-12-14 1:03 ` Andrew Morton
2007-12-14 1:03 ` Andrew Morton
2007-12-14 4:00 ` Matthew Wilcox
2007-12-14 4:00 ` Matthew Wilcox
2007-12-15 1:09 ` QUEUE_FLAG_CLUSTER: not working in 2.6.24 ? Mel Gorman
2007-12-15 1:09 ` Mel Gorman
2007-12-15 2:02 ` Andrew Morton
2007-12-15 2:02 ` Andrew Morton
2007-12-15 5:55 ` Matt Mackall
2007-12-15 5:55 ` Matt Mackall
2007-12-16 21:55 ` Mel Gorman
2007-12-16 21:55 ` Mel Gorman
2007-12-17 19:24 ` Randy Dunlap
2007-12-17 19:24 ` Randy Dunlap
2007-12-18 2:42 ` Matt Mackall
2007-12-18 2:42 ` Matt Mackall
2007-12-13 22:17 ` Jens Axboe
2007-12-13 22:17 ` Jens Axboe
2007-12-13 22:02 ` VM allocates pages in reverse order again Matthew Wilcox
2007-12-13 22:02 ` Matthew Wilcox
2007-12-13 19:37 ` QUEUE_FLAG_CLUSTER: not working in 2.6.24 ? Jens Axboe
2007-12-13 19:53 ` Mark Lord
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4762CBB6.5030301@rtr.ca \
--to=liml@rtr.ca \
--cc=James.Bottomley@HansenPartnership.com \
--cc=akpm@linux-foundation.org \
--cc=jens.axboe@oracle.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-scsi@vger.kernel.org \
--cc=lkml@rtr.ca \
--cc=matthew@wil.cx \
--cc=mel@csn.ul.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.