From: Scott Wood <scottwood-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
To: Anton Vorontsov <avorontsov-hkdhdckH98+B+jHODAdFcQ@public.gmane.org>
Cc: linuxppc-dev-mnsaURCQ41sdnm+yROfE0A@public.gmane.org,
spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: [PATCH 3/4] [POWERPC][SPI] use brg-frequency for SPI in QE
Date: Wed, 19 Dec 2007 14:58:53 -0600 [thread overview]
Message-ID: <4769860D.9040401@freescale.com> (raw)
In-Reply-To: <20071219203805.GC20861-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
Anton Vorontsov wrote:
> diff --git a/arch/powerpc/sysdev/fsl_soc.c b/arch/powerpc/sysdev/fsl_soc.c
> index 044dd7f..3cf84d0 100644
> --- a/arch/powerpc/sysdev/fsl_soc.c
> +++ b/arch/powerpc/sysdev/fsl_soc.c
> @@ -1227,15 +1227,19 @@ int __init fsl_spi_init(struct spi_board_info *board_infos,
>
> /* SPI controller is either clocked from QE or SoC clock */
> np = of_find_compatible_node(NULL, NULL, "fsl,qe");
> - if (!np)
> + if (np) {
> + sysclk = of_get_property(np, "brg-frequency", NULL);
> + if (!sysclk)
> + return -ENODEV;
> + } else {
You should use get_brgfreq() instead (and fix the legacy match to find
qe as well as soc nodes).
-Scott
-------------------------------------------------------------------------
SF.Net email is sponsored by:
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services
for just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
WARNING: multiple messages have this Message-ID (diff)
From: Scott Wood <scottwood@freescale.com>
To: Anton Vorontsov <avorontsov@ru.mvista.com>
Cc: linuxppc-dev@ozlabs.org, spi-devel-general@lists.sourceforge.net
Subject: Re: [PATCH 3/4] [POWERPC][SPI] use brg-frequency for SPI in QE
Date: Wed, 19 Dec 2007 14:58:53 -0600 [thread overview]
Message-ID: <4769860D.9040401@freescale.com> (raw)
In-Reply-To: <20071219203805.GC20861@localhost.localdomain>
Anton Vorontsov wrote:
> diff --git a/arch/powerpc/sysdev/fsl_soc.c b/arch/powerpc/sysdev/fsl_soc.c
> index 044dd7f..3cf84d0 100644
> --- a/arch/powerpc/sysdev/fsl_soc.c
> +++ b/arch/powerpc/sysdev/fsl_soc.c
> @@ -1227,15 +1227,19 @@ int __init fsl_spi_init(struct spi_board_info *board_infos,
>
> /* SPI controller is either clocked from QE or SoC clock */
> np = of_find_compatible_node(NULL, NULL, "fsl,qe");
> - if (!np)
> + if (np) {
> + sysclk = of_get_property(np, "brg-frequency", NULL);
> + if (!sysclk)
> + return -ENODEV;
> + } else {
You should use get_brgfreq() instead (and fix the legacy match to find
qe as well as soc nodes).
-Scott
next prev parent reply other threads:[~2007-12-19 20:58 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-19 20:34 [PATCH 0/4] device_type/compatible cleanups Anton Vorontsov
2007-12-19 20:34 ` Scott Wood
2007-12-19 20:48 ` Anton Vorontsov
2007-12-19 21:07 ` Scott Wood
2007-12-19 20:37 ` [PATCH 1/4] [POWERPC] qe_lib and users: get rid of device_type and model Anton Vorontsov
2007-12-19 20:37 ` [PATCH 2/4] [POWERPC][NET] ucc_geth_mii and users: get rid of device_type Anton Vorontsov
2007-12-19 20:37 ` Anton Vorontsov
[not found] ` <20071219203447.GA18285-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2007-12-19 20:38 ` [PATCH 3/4] [POWERPC][SPI] use brg-frequency for SPI in QE Anton Vorontsov
2007-12-19 20:38 ` Anton Vorontsov
[not found] ` <20071219203805.GC20861-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2007-12-19 20:58 ` Scott Wood [this message]
2007-12-19 20:58 ` Scott Wood
2007-12-19 23:27 ` Stephen Rothwell
2007-12-19 23:27 ` Stephen Rothwell
2007-12-19 20:38 ` [PATCH 4/4] [POWERPC] fsl_spi_init and users: stop using device_type = "spi" Anton Vorontsov
2007-12-19 20:54 ` Kumar Gala
2007-12-19 21:02 ` Anton Vorontsov
2007-12-19 21:04 ` Timur Tabi
2007-12-19 21:12 ` Anton Vorontsov
2007-12-19 21:15 ` Timur Tabi
2007-12-19 21:38 ` Grant Likely
2007-12-19 23:50 ` Olof Johansson
-- strict thread matches above, loose matches on Subject: below --
2007-12-21 20:18 [PATCH v3 0/4] device_type/compatible cleanups Anton Vorontsov
2007-12-21 20:21 ` [PATCH 3/4] [POWERPC][SPI] use brg-frequency for SPI in QE Anton Vorontsov
2008-01-08 14:26 [PATCH v4 0/4] device_type/compatible cleanups Anton Vorontsov
2008-01-08 14:30 ` [PATCH 3/4] [POWERPC][SPI] use brg-frequency for SPI in QE Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4769860D.9040401@freescale.com \
--to=scottwood-kzfg59tc24xl57midrcfdg@public.gmane.org \
--cc=avorontsov-hkdhdckH98+B+jHODAdFcQ@public.gmane.org \
--cc=linuxppc-dev-mnsaURCQ41sdnm+yROfE0A@public.gmane.org \
--cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.