[MIPS] MEM_SDREFCFG is not defined for Alchemy DB1550 (compile fail)

[MIPS] MEM_SDREFCFG is not defined for Alchemy DB1550 (compile fail)

[Alon Bar-Lev]

Hello,

When I have:
CONFIG_MIPS_DB1550
CONFIG_SOC_AU1550
CONFIG_SOC_AU1X00
CONFIG_PM

MEM_SDREFCFG is used at:
arch/mips/au1000/common/power.c::pm_do_freq()

While the MEM_SDREFCFG constant is declare only for CONFIG_SOC_AU1000,
CONFIG_SOC_AU1500, CONFIG_SOC_AU1100 at:
include/asm-mips/mach-au1x00/au1000.h

Maybe MEM_SDREFCFG should be defined for CONFIG_SOC_AU1X00?
Or there should be #ifdef for its usage in power.c?

Best Regards,
Alon Bar-Lev.

Re: [MIPS] MEM_SDREFCFG is not defined for Alchemy DB1550 (compile fail)

[Alon Bar-Lev]

Hello,

Forgot to write that I checked mips & linus gits, and the problem still exists.

Best Regards,
Alon Bar-Lev.

On 12/23/07, Alon Bar-Lev <alon.barlev@gmail.com> wrote:
> Hello,
>
> When I have:
> CONFIG_MIPS_DB1550
> CONFIG_SOC_AU1550
> CONFIG_SOC_AU1X00
> CONFIG_PM
>
> MEM_SDREFCFG is used at:
> arch/mips/au1000/common/power.c::pm_do_freq()
>
> While the MEM_SDREFCFG constant is declare only for CONFIG_SOC_AU1000,
> CONFIG_SOC_AU1500, CONFIG_SOC_AU1100 at:
> include/asm-mips/mach-au1x00/au1000.h
>
> Maybe MEM_SDREFCFG should be defined for CONFIG_SOC_AU1X00?
> Or there should be #ifdef for its usage in power.c?
>
> Best Regards,
> Alon Bar-Lev.
>

Re: [MIPS] MEM_SDREFCFG is not defined for Alchemy DB1550 (compile fail)

[Sergei Shtylyov]

Hello.

Alon Bar-Lev wrote:

> When I have:
> CONFIG_MIPS_DB1550
> CONFIG_SOC_AU1550
> CONFIG_SOC_AU1X00
> CONFIG_PM

> MEM_SDREFCFG is used at:
> arch/mips/au1000/common/power.c::pm_do_freq()

    PM code is generally broken and unmaintained, so no wonder. I don't 
remember if anyone has fixed CPU context restoration code (it uses a "skewed" 
stack frame).

> While the MEM_SDREFCFG constant is declare only for CONFIG_SOC_AU1000,
> CONFIG_SOC_AU1500, CONFIG_SOC_AU1100 at:
> include/asm-mips/mach-au1x00/au1000.h

> Maybe MEM_SDREFCFG should be defined for CONFIG_SOC_AU1X00?

    I've just looked into the Au1550 datasheet and indeed it doesn't have such 
register; its SDDRAM controller is not compatible with older SoCs.

> Or there should be #ifdef for its usage in power.c?

    Looks like you'll have to invent something... ;-)

> Best Regards,
> Alon Bar-Lev.

WBR, Sergei

Re: [MIPS] MEM_SDREFCFG is not defined for Alchemy DB1550 (compile fail)

[Ralf Baechle]

On Tue, Dec 25, 2007 at 01:41:21PM +0300, Sergei Shtylyov wrote:

>> When I have:
>> CONFIG_MIPS_DB1550
>> CONFIG_SOC_AU1550
>> CONFIG_SOC_AU1X00
>> CONFIG_PM
>
>> MEM_SDREFCFG is used at:
>> arch/mips/au1000/common/power.c::pm_do_freq()
>
>    PM code is generally broken and unmaintained, so no wonder. I don't 
> remember if anyone has fixed CPU context restoration code (it uses a 
> "skewed" stack frame).
>
>> While the MEM_SDREFCFG constant is declare only for CONFIG_SOC_AU1000,
>> CONFIG_SOC_AU1500, CONFIG_SOC_AU1100 at:
>> include/asm-mips/mach-au1x00/au1000.h
>
>> Maybe MEM_SDREFCFG should be defined for CONFIG_SOC_AU1X00?
>
>    I've just looked into the Au1550 datasheet and indeed it doesn't have 
> such register; its SDDRAM controller is not compatible with older SoCs.
>
>> Or there should be #ifdef for its usage in power.c?
>
>    Looks like you'll have to invent something... ;-)
>
>> Best Regards,
>> Alon Bar-Lev.

So I guess it's time to mark the whole PM stuff as BROKEN?

  Ralf

Re: [MIPS] MEM_SDREFCFG is not defined for Alchemy DB1550 (compile fail)

[Alon Bar-Lev]

Thank you for your reply!

On 12/25/07, Sergei Shtylyov <sshtylyov@ru.mvista.com> wrote:
>     PM code is generally broken and unmaintained, so no wonder. I don't
> remember if anyone has fixed CPU context restoration code (it uses a "skewed"
> stack frame).

So suspend modes on these boards are not supported?
Only "Always On" configuration is supported?
Or there is another method to preserve power?

Best Regards,
Alon Bar-Lev.

Re: [MIPS] MEM_SDREFCFG is not defined for Alchemy DB1550 (compile fail)

[Sergei Shtylyov]

Alon Bar-Lev wrote:

>>    PM code is generally broken and unmaintained, so no wonder. I don't
>>remember if anyone has fixed CPU context restoration code (it uses a "skewed"
>>stack frame).

> So suspend modes on these boards are not supported?
> Only "Always On" configuration is supported?

    Sleep mode is supported according to the code. But as I've said PM bits 
haven't been maintained -- probably since the submission.

> Best Regards,
> Alon Bar-Lev.

WBR, Sergei

Re: [MIPS] MEM_SDREFCFG is not defined for Alchemy DB1550 (compile fail)

[Alon Bar-Lev]

On 12/25/07, Sergei Shtylyov <sshtylyov@ru.mvista.com> wrote:
> > So suspend modes on these boards are not supported?
> > Only "Always On" configuration is supported?
>
>     Sleep mode is supported according to the code. But as I've said PM bits
> haven't been maintained -- probably since the submission.

Thanks!
Will it be maintained? Are there any plans?
Is there, a missing features list (TODO)?
Or this is completely unsupported board?

Best Regards,
Alon Bar-Lev.