All of lore.kernel.org
 help / color / mirror / Atom feed
From: gvb.uboot <gvb.uboot@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH 2/2] Remove the obsolete terse version of do_mii()
Date: Sat, 29 Dec 2007 07:38:10 -0500	[thread overview]
Message-ID: <47763FB2.50508@gmail.com> (raw)
In-Reply-To: <477472A3.4020201@necel.com>

Shinya Kuribayashi wrote:
> We now have more useful version of do_mii() and everybody use it. Grald
> Van Baren says
> 
>> When I originally wrote the mii command 6(!) years ago, I wrote a 
>> verbose version that printed human readable decomposition of the flags, 
>> etc., and a terse one that didn't print as much stuff and thus had a 
>> smaller memory footprint.
>>
>> It sounds like the terse version has withered and died, apparently 
>> people are only using the verbose version (which is very understandable, 
>> I do myself).
> 
> Signed-off-by: Shinya Kuribayashi <shinya.kuribayashi@necel.com>
> Signed-off-by: Gerald Van Baren <vanbaren@cideas.com>

Hi Shinya,

Thanks for the patch to clean this up.  While I agree with the patch, I 
would appreciate respinning it:
* I should be an "Acked by" rather than a signed off by since I didn't 
do anything to generate the patch itself.

* I would also offer the following summary rather than quoting my 
original email (including the 6(!) year reference, which will look kinda 
funny in 2012 ;-):

Remove the "terse" version of the mii command, eliminating an #ifdef and 
apparently unused code.  The space savings of the "terse" version is not 
significant and it isn't worth the extra maintenance effort to keep it.

Acked-by: Gerald Van Baren <vanbaren@cideas.com>

Thanks,
gvb

  reply	other threads:[~2007-12-29 12:38 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-28  3:50 [U-Boot-Users] [PATCH 2/2] Remove the obsolete terse version of do_mii() Shinya Kuribayashi
2007-12-29 12:38 ` gvb.uboot [this message]
2008-01-04  4:30   ` Shinya Kuribayashi
2008-01-04 12:38     ` Jerry Van Baren
2008-01-07  5:32 ` [U-Boot-Users] [PATCH] Remove the "terse" " Shinya Kuribayashi
2008-01-09 20:44 ` [U-Boot-Users] [PATCH 2/2] Remove the obsolete terse " Wolfgang Denk
2008-01-09 20:46   ` Jerry Van Baren
2008-01-09 20:48   ` Jerry Van Baren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47763FB2.50508@gmail.com \
    --to=gvb.uboot@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.