All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jerry Van Baren <gerald.vanbaren@ge.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH 2/2] Remove the obsolete terse version of do_mii()
Date: Fri, 04 Jan 2008 07:38:06 -0500	[thread overview]
Message-ID: <477E28AE.1020400@ge.com> (raw)
In-Reply-To: <477DB676.70406@ruby.dti.ne.jp>

Shinya Kuribayashi wrote:
> gvb.uboot wrote:
>> Thanks for the patch to clean this up.  While I agree with the patch, 
>> I would appreciate respinning it:
>> * I should be an "Acked by" rather than a signed off by since I didn't 
>> do anything to generate the patch itself.
> 
> As you are the original writer, IMHO you could/should signed-off-by :-)
> But it was my bad to add your sign without asking you. I'll resubmit the
> patch later with your acked-by.

I figure that an acked-by is more appropriate than a signed-off-by 
because, while I approve of the patch, I didn't actually contribute to 
it directly (I contributed the anti-patch, that is, the code that is 
being removed... but that already has my signed-off-by on it).

> Thanks for your kind summary.
> 
>  Shinya

Thanks for rerolling,
gvb

  reply	other threads:[~2008-01-04 12:38 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-28  3:50 [U-Boot-Users] [PATCH 2/2] Remove the obsolete terse version of do_mii() Shinya Kuribayashi
2007-12-29 12:38 ` gvb.uboot
2008-01-04  4:30   ` Shinya Kuribayashi
2008-01-04 12:38     ` Jerry Van Baren [this message]
2008-01-07  5:32 ` [U-Boot-Users] [PATCH] Remove the "terse" " Shinya Kuribayashi
2008-01-09 20:44 ` [U-Boot-Users] [PATCH 2/2] Remove the obsolete terse " Wolfgang Denk
2008-01-09 20:46   ` Jerry Van Baren
2008-01-09 20:48   ` Jerry Van Baren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=477E28AE.1020400@ge.com \
    --to=gerald.vanbaren@ge.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.