From: Johannes Sixt <j.sixt@viscovery.net>
To: Imran M Yousuf <imyousuf@gmail.com>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH] Simplified the invocation of command action in submodule
Date: Wed, 09 Jan 2008 11:01:04 +0100 [thread overview]
Message-ID: <47849B60.2060000@viscovery.net> (raw)
In-Reply-To: <7bfdc29a0801090151k22d3cd5aqedb0d4860868d4d9@mail.gmail.com>
Imran M Yousuf schrieb:
> On Jan 9, 2008 2:59 PM, Johannes Sixt <j.sixt@viscovery.net> wrote:
>> - Previously, passing --cached to add, init, or update was an error, now
>> it is not.
>
> The usage statement and this behaviour is rather contradicting. The
> usage says that --cached can be used with all commands; so I am not
> sure whether using --cached with add should be an error or not. IMHO,
> if the previous implementation was right than the USAGE has to be
> changed, and if the previous implementation was incorrect, than if the
> default command is set to status than current implementation is right.
I prefer that the usage statement lists one line per sub-command with the
flags that apply only to the sub-command. IOW, a usage statement that
suggests that a flag applies to all sub-commands when in reality it
doesn't is bogus, IMHO.
-- Hannes
next prev parent reply other threads:[~2008-01-09 10:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-09 3:59 [PATCH] Simplified the invocation of command action in submodule imyousuf
2008-01-09 8:19 ` Junio C Hamano
2008-01-09 8:23 ` Imran M Yousuf
2008-01-09 8:59 ` Johannes Sixt
2008-01-09 9:07 ` Imran M Yousuf
2008-01-09 9:15 ` Johannes Sixt
2008-01-09 9:51 ` Imran M Yousuf
2008-01-09 10:01 ` Johannes Sixt [this message]
2008-01-09 10:06 ` Imran M Yousuf
2008-01-09 10:27 ` Junio C Hamano
2008-01-09 10:24 ` Lars Hjemli
2008-01-10 3:05 ` Imran M Yousuf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47849B60.2060000@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=imyousuf@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.