All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Travis <travis@sgi.com>
To: Jan Engelhardt <jengelh@computergmbh.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Andi Kleen <ak@suse.de>,
	mingo@elte.hu, Christoph Lameter <clameter@sgi.com>,
	Jack Steiner <steiner@sgi.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 06/10] x86: Change NR_CPUS arrays in topology
Date: Mon, 14 Jan 2008 11:08:38 -0800	[thread overview]
Message-ID: <478BB336.5000004@sgi.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0801141925070.24893@fbirervta.pbzchgretzou.qr>

Jan Engelhardt wrote:
> On Jan 13 2008 10:34, travis@sgi.com wrote:
>> +++ b/include/asm-x86/cpu.h
>> @@ -7,7 +7,7 @@
>> #include <linux/nodemask.h>
>> #include <linux/percpu.h>
>>
>> -struct i386_cpu {
>> +struct x86_cpu {
>> 	struct cpu cpu;
>> };
>> extern int arch_register_cpu(int num);
> 
> Is not struct x86_cpu kinda redundant here if it only wraps around
> one member?

Looking at it, I think the x86 arch specific include file
is including the generic struct cpu (instead of say, a
different one)...?

Thanks,
Mike

WARNING: multiple messages have this Message-ID (diff)
From: Mike Travis <travis@sgi.com>
To: Jan Engelhardt <jengelh@computergmbh.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Andi Kleen <ak@suse.de>,
	mingo@elte.hu, Christoph Lameter <clameter@sgi.com>,
	Jack Steiner <steiner@sgi.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 06/10] x86: Change NR_CPUS arrays in topology
Date: Mon, 14 Jan 2008 11:08:38 -0800	[thread overview]
Message-ID: <478BB336.5000004@sgi.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0801141925070.24893@fbirervta.pbzchgretzou.qr>

Jan Engelhardt wrote:
> On Jan 13 2008 10:34, travis@sgi.com wrote:
>> +++ b/include/asm-x86/cpu.h
>> @@ -7,7 +7,7 @@
>> #include <linux/nodemask.h>
>> #include <linux/percpu.h>
>>
>> -struct i386_cpu {
>> +struct x86_cpu {
>> 	struct cpu cpu;
>> };
>> extern int arch_register_cpu(int num);
> 
> Is not struct x86_cpu kinda redundant here if it only wraps around
> one member?

Looking at it, I think the x86 arch specific include file
is including the generic struct cpu (instead of say, a
different one)...?

Thanks,
Mike

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2008-01-14 19:08 UTC|newest]

Thread overview: 66+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-13 18:34 [PATCH 00/10] x86: Reduce memory and intra-node effects with large count NR_CPUs travis
2008-01-13 18:34 ` travis
2008-01-13 18:34 ` [PATCH 01/10] x86: Change size of APICIDs from u8 to u16 travis
2008-01-13 18:34   ` travis
2008-01-14 12:23   ` Mel Gorman
2008-01-14 12:23     ` Mel Gorman
2008-01-14 18:13     ` Mike Travis
2008-01-14 18:13       ` Mike Travis
2008-01-14 19:26     ` Mike Travis
2008-01-14 19:26       ` Mike Travis
2008-01-14 18:10   ` Jan Engelhardt
2008-01-14 18:10     ` Jan Engelhardt
2008-01-14 18:22     ` Mike Travis
2008-01-14 18:22       ` Mike Travis
2008-01-14 18:32     ` Mike Travis
2008-01-14 18:32       ` Mike Travis
2008-01-14 19:16       ` Christoph Lameter
2008-01-14 19:16         ` Christoph Lameter
2008-01-13 18:34 ` [PATCH 02/10] x86: Change size of node ids " travis
2008-01-13 18:34   ` travis
2008-01-13 20:01   ` Eric Dumazet
2008-01-13 20:01     ` Eric Dumazet
2008-01-13 18:34 ` [PATCH 03/10] x86: Change NR_CPUS arrays in powernow-k8 travis
2008-01-13 18:34   ` travis
2008-01-13 18:34 ` [PATCH 04/10] x86: Change NR_CPUS arrays in intel_cacheinfo travis
2008-01-13 18:34   ` travis
2008-01-13 18:34 ` [PATCH 05/10] x86: Change NR_CPUS arrays in smpboot_64 travis
2008-01-13 18:34   ` travis
2008-01-13 18:34 ` [PATCH 06/10] x86: Change NR_CPUS arrays in topology travis
2008-01-13 18:34   ` travis
2008-01-14 18:25   ` Jan Engelhardt
2008-01-14 18:25     ` Jan Engelhardt
2008-01-14 19:08     ` Mike Travis [this message]
2008-01-14 19:08       ` Mike Travis
2008-01-13 18:35 ` [PATCH 07/10] x86: Cleanup x86_cpu_to_apicid references travis
2008-01-13 18:35   ` travis
2008-01-13 18:35 ` [PATCH 08/10] x86: Change NR_CPUS arrays in numa_64 travis
2008-01-13 18:35   ` travis
2008-01-14 11:14   ` Ingo Molnar
2008-01-14 11:14     ` Ingo Molnar
2008-01-14 17:17     ` Mike Travis
2008-01-14 17:17       ` Mike Travis
2008-01-14 18:14   ` Jan Engelhardt
2008-01-14 18:14     ` Jan Engelhardt
2008-01-13 18:35 ` [PATCH 09/10] x86: Change NR_CPUS arrays in acpi-cpufreq travis
2008-01-13 18:35   ` travis
2008-01-13 18:35 ` [PATCH 10/10] x86: Change bios_cpu_apicid to percpu data variable travis
2008-01-13 18:35   ` travis
2008-01-14  8:14 ` [PATCH 00/10] x86: Reduce memory and intra-node effects with large count NR_CPUs Ingo Molnar
2008-01-14  8:14   ` Ingo Molnar
2008-01-14  9:00   ` Ingo Molnar
2008-01-14  9:00     ` Ingo Molnar
2008-01-14 17:52     ` Mike Travis
2008-01-14 17:52       ` Mike Travis
2008-01-14 10:04   ` Andi Kleen
2008-01-14 10:04     ` Andi Kleen
2008-01-14 10:11     ` Ingo Molnar
2008-01-14 10:11       ` Ingo Molnar
2008-01-14 11:30       ` Andi Kleen
2008-01-14 11:30         ` Andi Kleen
2008-01-16  7:34         ` Nick Piggin
2008-01-16  7:34           ` Nick Piggin
2008-01-16 18:07           ` Christoph Lameter
2008-01-16 18:07             ` Christoph Lameter
2008-01-14 18:00       ` Mike Travis
2008-01-14 18:00         ` Mike Travis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=478BB336.5000004@sgi.com \
    --to=travis@sgi.com \
    --cc=ak@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=clameter@sgi.com \
    --cc=jengelh@computergmbh.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mingo@elte.hu \
    --cc=steiner@sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.