From: "Timo Teräs" <timo.teras@iki.fi>
To: David Miller <davem@davemloft.net>
Cc: herbert@gondor.apana.org.au, hadi@cyberus.ca, netdev@vger.kernel.org
Subject: Re: [RFC][PATCH] Fixing SA/SP dumps on netlink/af_key
Date: Thu, 17 Jan 2008 12:01:17 +0200 [thread overview]
Message-ID: <478F276D.8080407@iki.fi> (raw)
In-Reply-To: <20080117.014458.16733544.davem@davemloft.net>
David Miller wrote:
> From: Timo_Teräs <timo.teras@iki.fi>
> Date: Thu, 17 Jan 2008 11:38:13 +0200
>
>> The af_key issue is that in big dumps you get only first X
>> entries. The rest of the entries are dropped because the
>> socket receive buffer goes full. You get data corruption:
>> missing entries.
>
> This is an inherent aspect of AF_KEY (and what it was
> derived from, BSD routing sockets).
Yes, this is the way BSD does it.
> It has to provide dumps atomically, and if there is no
> space there is no way to provide those entries which
> would require more rcvbuf space.
RFC does not say it has to be atomic.
It does say that the dump is terminated with SADB_DUMP
message having sadb_seq field set to zero. Currently
that is dropped too when the problem occurs. Thus the
socket is left in a bad state: dump ends never. This
can cause applications without any workarounds to hang.
- Timo
next prev parent reply other threads:[~2008-01-17 10:00 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-13 12:26 [RFC][PATCH] Fixing SA/SP dumps on netlink/af_key Timo Teräs
2008-01-16 13:52 ` jamal
2008-01-16 14:28 ` Timo Teräs
2008-01-17 1:25 ` jamal
2008-01-16 22:58 ` Herbert Xu
2008-01-17 1:39 ` jamal
2008-01-17 2:17 ` Herbert Xu
2008-01-17 5:54 ` Timo Teräs
2008-01-17 11:11 ` Herbert Xu
2008-01-17 12:21 ` Timo Teräs
2008-01-17 12:26 ` jamal
2008-01-17 12:42 ` jamal
2008-01-17 12:50 ` Herbert Xu
2008-01-17 13:18 ` jamal
2008-01-17 13:31 ` Timo Teräs
2008-01-17 21:34 ` Herbert Xu
2008-01-18 6:45 ` Timo Teräs
2008-01-18 14:08 ` jamal
2008-01-17 6:27 ` Timo Teräs
2008-01-17 7:16 ` David Miller
2008-01-17 7:38 ` Timo Teräs
2008-01-17 7:59 ` David Miller
2008-01-17 8:11 ` Timo Teräs
2008-01-17 8:49 ` David Miller
2008-01-17 9:20 ` Timo Teräs
2008-01-17 9:31 ` David Miller
2008-01-17 9:38 ` Timo Teräs
2008-01-17 9:44 ` David Miller
2008-01-17 10:01 ` Timo Teräs [this message]
2008-01-17 10:06 ` David Miller
2008-01-17 11:00 ` Timo Teräs
2008-01-17 11:08 ` David Miller
2008-01-17 12:37 ` Timo Teräs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=478F276D.8080407@iki.fi \
--to=timo.teras@iki.fi \
--cc=davem@davemloft.net \
--cc=hadi@cyberus.ca \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.