All of lore.kernel.org
 help / color / mirror / Atom feed
* [lm-sensors] [PATCH] coretemp: Add Penryn CPU to coretemp
@ 2008-01-17 23:50 Rudolf Marek
  2008-02-14  8:23 ` Jean Delvare
  2008-02-18  3:08 ` Mark M. Hoffman
  0 siblings, 2 replies; 3+ messages in thread
From: Rudolf Marek @ 2008-01-17 23:50 UTC (permalink / raw)
  To: lm-sensors

[-- Attachment #1: Type: text/plain, Size: 529 bytes --]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hello,

This patch adds support for family 0x17, which has Penryn Core. It should also
cover the 8 cores Xeons.

Can someone test please? I think it should work.

Signed-off-by: Rudolf Marek <r.marek@assembler.cz>

Thanks,
Rudolf
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHj+ms3J9wPJqZRNURAqKoAJwLGJSgU2k1ke0Gn3550qMaWfIyGQCgimyV
Fl8HRd1y4ecNQ7SqSMx3RL0=
=8BPU
-----END PGP SIGNATURE-----

[-- Attachment #2: add-penryn.patch --]
[-- Type: text/x-patch, Size: 1465 bytes --]

Index: linux-2.6.24-rc7/drivers/hwmon/coretemp.c
===================================================================
--- linux-2.6.24-rc7.orig/drivers/hwmon/coretemp.c	2008-01-18 00:32:26.147387823 +0100
+++ linux-2.6.24-rc7/drivers/hwmon/coretemp.c	2008-01-18 00:33:49.220121868 +0100
@@ -414,10 +414,10 @@
 	for_each_online_cpu(i) {
 		struct cpuinfo_x86 *c = &cpu_data(i);
 
-		/* check if family 6, models e, f, 16 */
+		/* check if family 6, models 0xe, 0xf, 0x16, 0x17 */
 		if ((c->cpuid_level < 0) || (c->x86 != 0x6) ||
 		    !((c->x86_model == 0xe) || (c->x86_model == 0xf) ||
-			(c->x86_model == 0x16))) {
+			(c->x86_model == 0x16) || (c->x86_model == 0x17))) {
 
 			/* supported CPU not found, but report the unknown
 			   family 6 CPU */
Index: linux-2.6.24-rc7/Documentation/hwmon/coretemp
===================================================================
--- linux-2.6.24-rc7.orig/Documentation/hwmon/coretemp	2008-01-18 00:34:00.776780445 +0100
+++ linux-2.6.24-rc7/Documentation/hwmon/coretemp	2008-01-18 00:35:39.646414704 +0100
@@ -4,9 +4,10 @@
 Supported chips:
   * All Intel Core family
     Prefix: 'coretemp'
-    CPUID: family 0x6, models 0xe, 0xf, 0x16
+    CPUID: family 0x6, models 0xe, 0xf, 0x16, 0x17
     Datasheet: Intel 64 and IA-32 Architectures Software Developer's Manual
                Volume 3A: System Programming Guide
+               http://softwarecommunity.intel.com/Wiki/Mobility/720.htm
 
 Author: Rudolf Marek
 

[-- Attachment #3: Type: text/plain, Size: 153 bytes --]

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [lm-sensors] [PATCH] coretemp: Add Penryn CPU to coretemp
  2008-01-17 23:50 [lm-sensors] [PATCH] coretemp: Add Penryn CPU to coretemp Rudolf Marek
@ 2008-02-14  8:23 ` Jean Delvare
  2008-02-18  3:08 ` Mark M. Hoffman
  1 sibling, 0 replies; 3+ messages in thread
From: Jean Delvare @ 2008-02-14  8:23 UTC (permalink / raw)
  To: lm-sensors

Hi Rudolf,

On Fri, 18 Jan 2008 00:50:04 +0100, Rudolf Marek wrote:
> This patch adds support for family 0x17, which has Penryn Core. It should also
> cover the 8 cores Xeons.
> 
> Can someone test please? I think it should work.

I only have a T2600 (Core Duo), I confirm that there is no regression
with this patch.

> 
> Signed-off-by: Rudolf Marek <r.marek@assembler.cz>

Review: looks OK to me.

Acked-by: Jean Delvare <khali@linux-fr.org>

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [lm-sensors] [PATCH] coretemp: Add Penryn CPU to coretemp
  2008-01-17 23:50 [lm-sensors] [PATCH] coretemp: Add Penryn CPU to coretemp Rudolf Marek
  2008-02-14  8:23 ` Jean Delvare
@ 2008-02-18  3:08 ` Mark M. Hoffman
  1 sibling, 0 replies; 3+ messages in thread
From: Mark M. Hoffman @ 2008-02-18  3:08 UTC (permalink / raw)
  To: lm-sensors

Hi Rudolf:

* Jean Delvare <khali@linux-fr.org> [2008-02-14 09:23:23 +0100]:
> Hi Rudolf,
> 
> On Fri, 18 Jan 2008 00:50:04 +0100, Rudolf Marek wrote:
> > This patch adds support for family 0x17, which has Penryn Core. It should also
> > cover the 8 cores Xeons.
> > 
> > Can someone test please? I think it should work.
> 
> I only have a T2600 (Core Duo), I confirm that there is no regression
> with this patch.
> 
> > 
> > Signed-off-by: Rudolf Marek <r.marek@assembler.cz>
> 
> Review: looks OK to me.
> 
> Acked-by: Jean Delvare <khali@linux-fr.org>

Applied to hwmon-2.6.git/testing, thanks.

-- 
Mark M. Hoffman
mhoffman@lightlink.com


_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2008-02-18  3:08 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-01-17 23:50 [lm-sensors] [PATCH] coretemp: Add Penryn CPU to coretemp Rudolf Marek
2008-02-14  8:23 ` Jean Delvare
2008-02-18  3:08 ` Mark M. Hoffman

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.