All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Travis <travis@sgi.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Andi Kleen <ak@suse.de>,
	mingo@elte.hu, Christoph Lameter <clameter@sgi.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Rusty Russell <rusty@rustcorp.com.au>
Subject: Re: [PATCH 2/6] percpu: Change Kconfig ARCH_SETS_UP_PER_CPU_AREA to HAVE_SETUP_PER_CPU_AREA
Date: Fri, 18 Jan 2008 04:46:28 -0800	[thread overview]
Message-ID: <47909FA4.1020205@sgi.com> (raw)
In-Reply-To: <20080118051118.GA14882@uranus.ravnborg.org>

Sam Ravnborg wrote:
> Hi Mike.
> 
>> --- a/arch/x86/Kconfig
>> +++ b/arch/x86/Kconfig
>> @@ -20,6 +20,7 @@ config X86
>>  	def_bool y
>>  	select HAVE_OPROFILE
>>  	select HAVE_KPROBES
>> +	select HAVE_SETUP_PER_CPU_AREA if ARCH = "x86_64"
> 
> It is simpler to just say:
>> +	select HAVE_SETUP_PER_CPU_AREA if X86_64
> 
> And this is the way we do it in the rest of the
> x86 Kconfig files.
> 
> 	Sam


Thanks.  Done. :-)

And sorry about the premature mailing.  I have a set of scripts that
package everything up to send to test machines and it wasn't supposed
to trigger the "sendmail" phase to the distro list.  There are a few
build errors (as Ingo has noted) and I'm debugging an X86_64 !NUMA
problem that dies at network startup time.

But I'll add in all the suggestions from the "premature" reviews... :-)

Thanks again,
Mike

WARNING: multiple messages have this Message-ID (diff)
From: Mike Travis <travis@sgi.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Andi Kleen <ak@suse.de>,
	mingo@elte.hu, Christoph Lameter <clameter@sgi.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Rusty Russell <rusty@rustcorp.com.au>
Subject: Re: [PATCH 2/6] percpu: Change Kconfig ARCH_SETS_UP_PER_CPU_AREA to HAVE_SETUP_PER_CPU_AREA
Date: Fri, 18 Jan 2008 04:46:28 -0800	[thread overview]
Message-ID: <47909FA4.1020205@sgi.com> (raw)
In-Reply-To: <20080118051118.GA14882@uranus.ravnborg.org>

Sam Ravnborg wrote:
> Hi Mike.
> 
>> --- a/arch/x86/Kconfig
>> +++ b/arch/x86/Kconfig
>> @@ -20,6 +20,7 @@ config X86
>>  	def_bool y
>>  	select HAVE_OPROFILE
>>  	select HAVE_KPROBES
>> +	select HAVE_SETUP_PER_CPU_AREA if ARCH = "x86_64"
> 
> It is simpler to just say:
>> +	select HAVE_SETUP_PER_CPU_AREA if X86_64
> 
> And this is the way we do it in the rest of the
> x86 Kconfig files.
> 
> 	Sam


Thanks.  Done. :-)

And sorry about the premature mailing.  I have a set of scripts that
package everything up to send to test machines and it wasn't supposed
to trigger the "sendmail" phase to the distro list.  There are a few
build errors (as Ingo has noted) and I'm debugging an X86_64 !NUMA
problem that dies at network startup time.

But I'll add in all the suggestions from the "premature" reviews... :-)

Thanks again,
Mike

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2008-01-18 12:46 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-17 22:35 [PATCH 0/6] percpu: Per cpu code simplification fixup travis
2008-01-17 22:35 ` travis
2008-01-17 22:35 ` [PATCH 1/6] Modules: Fold percpu_modcopy into module.c travis
2008-01-17 22:35   ` travis
2008-01-17 22:35 ` [PATCH 2/6] percpu: Change Kconfig ARCH_SETS_UP_PER_CPU_AREA to HAVE_SETUP_PER_CPU_AREA travis
2008-01-17 22:35   ` travis
2008-01-18  5:11   ` Sam Ravnborg
2008-01-18  5:11     ` Sam Ravnborg
2008-01-18 12:46     ` Mike Travis [this message]
2008-01-18 12:46       ` Mike Travis
2008-01-18 15:46     ` Mike Travis
2008-01-18 15:46       ` Mike Travis
2008-01-17 22:35 ` [PATCH 3/6] Sparc64: Use generic percpu travis
2008-01-17 22:35   ` travis
2008-01-17 22:35 ` [PATCH 4/6] ia64: " travis
2008-01-17 22:35   ` travis
2008-01-17 22:35   ` travis
2008-01-17 22:35 ` [PATCH 5/6] Powerpc: Use generic per cpu travis
2008-01-17 22:35   ` travis
2008-01-17 22:35 ` [PATCH 6/6] s390: Use generic percpu travis
2008-01-17 22:35   ` travis
2008-01-17 22:41 ` [PATCH 0/6] percpu: Per cpu code simplification fixup Mike Travis
2008-01-17 22:41   ` Mike Travis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47909FA4.1020205@sgi.com \
    --to=travis@sgi.com \
    --cc=ak@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=clameter@sgi.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mingo@elte.hu \
    --cc=rusty@rustcorp.com.au \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.