From: Cedric Le Goater <clg-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org>
To: Pavel Machek <pavel-+ZI9xUNit7I@public.gmane.org>
Cc: Linux Containers
<containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org>,
Andrew Morton
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
Linux Kernel Mailing List
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Pavel Emelyanov <xemul-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org>
Subject: Re: [PATCH 1/2] Extend sys_clone and sys_unshare system calls API
Date: Thu, 24 Jan 2008 18:09:56 +0100 [thread overview]
Message-ID: <4798C664.1040409@fr.ibm.com> (raw)
In-Reply-To: <20080123205930.GA5233-+ZI9xUNit7I@public.gmane.org>
Pavel Machek wrote:
> On Wed 2008-01-16 15:58:55, Pavel Emelyanov wrote:
>> There's only one bit in the clone_flags left, so we won't be able
>> to create more namespaces after we make it busy. Besides, for
>> checkpoint/restart jobs we might want to create tasks with given
>> pids (virtual of course). And nobody knows for sure what else might
>> be required from clone() in the future.
>>
>> This is an attempt to create a extendable API for clone and unshare.
>> Actually this patch is a request for comment about the overall
>> design. If it will turn out to "look good", then we'll select some
>> better names for new flag and data types.
>>
>> I use the last bit in the clone_flags for CLONE_LONGARG. When set it
>> will denote that the child_tidptr is not a pointer to a tid storage,
>> but the pointer to the struct long_clone_struct which currently
>> looks like this:
>>
>> struct long_clone_arg {
>> int size;
>> };
>
> Ugly as night, I'd say. (Al said it better). What about just adding
> clone2 syscall, that takes u64?
yes but we would need more something like :
long sys_clone64(unsigned long flags_high, unsigned long flag_low)
if we want the syscall to be supported on 32bit arch. clone2 is also
being used on ia64 already.
C.
WARNING: multiple messages have this Message-ID (diff)
From: Cedric Le Goater <clg@fr.ibm.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: Pavel Emelyanov <xemul@openvz.org>,
Linux Containers <containers@lists.osdl.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] Extend sys_clone and sys_unshare system calls API
Date: Thu, 24 Jan 2008 18:09:56 +0100 [thread overview]
Message-ID: <4798C664.1040409@fr.ibm.com> (raw)
In-Reply-To: <20080123205930.GA5233@ucw.cz>
Pavel Machek wrote:
> On Wed 2008-01-16 15:58:55, Pavel Emelyanov wrote:
>> There's only one bit in the clone_flags left, so we won't be able
>> to create more namespaces after we make it busy. Besides, for
>> checkpoint/restart jobs we might want to create tasks with given
>> pids (virtual of course). And nobody knows for sure what else might
>> be required from clone() in the future.
>>
>> This is an attempt to create a extendable API for clone and unshare.
>> Actually this patch is a request for comment about the overall
>> design. If it will turn out to "look good", then we'll select some
>> better names for new flag and data types.
>>
>> I use the last bit in the clone_flags for CLONE_LONGARG. When set it
>> will denote that the child_tidptr is not a pointer to a tid storage,
>> but the pointer to the struct long_clone_struct which currently
>> looks like this:
>>
>> struct long_clone_arg {
>> int size;
>> };
>
> Ugly as night, I'd say. (Al said it better). What about just adding
> clone2 syscall, that takes u64?
yes but we would need more something like :
long sys_clone64(unsigned long flags_high, unsigned long flag_low)
if we want the syscall to be supported on 32bit arch. clone2 is also
being used on ia64 already.
C.
next prev parent reply other threads:[~2008-01-24 17:09 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-16 12:58 [PATCH 1/2] Extend sys_clone and sys_unshare system calls API Pavel Emelyanov
2008-01-16 12:58 ` Pavel Emelyanov
2008-01-16 14:23 ` Jonathan Corbet
[not found] ` <9803.1200493420-k5ufJzZ057zk1uMJSBkQmQ@public.gmane.org>
2008-01-16 15:05 ` Pavel Emelyanov
2008-01-16 15:05 ` Pavel Emelyanov
2008-01-17 3:48 ` Al Viro
2008-01-17 9:28 ` Cedric Le Goater
2008-01-17 15:02 ` Extending syscalls (was: [PATCH 1/2] Extend sys_clone and sys_unshare system calls API) Jonathan Corbet
2008-01-17 19:26 ` Extending syscalls H. Peter Anvin
[not found] ` <478DFF8F.9030006-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org>
2008-01-16 13:00 ` [PATCH 2/2] Propagate the long_clone_arg up to the create_new_namespaces Pavel Emelyanov
2008-01-16 13:00 ` Pavel Emelyanov
2008-01-23 20:59 ` [PATCH 1/2] Extend sys_clone and sys_unshare system calls API Pavel Machek
2008-01-23 20:59 ` Pavel Machek
[not found] ` <20080123205930.GA5233-+ZI9xUNit7I@public.gmane.org>
2008-01-24 17:09 ` Cedric Le Goater [this message]
2008-01-24 17:09 ` Cedric Le Goater
2008-01-24 17:24 ` Dave Hansen
2008-01-24 17:37 ` Pavel Machek
2008-01-24 17:46 ` Dave Hansen
2008-01-24 17:50 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4798C664.1040409@fr.ibm.com \
--to=clg-nmtc/0zbporqt0dzr+alfa@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=pavel-+ZI9xUNit7I@public.gmane.org \
--cc=xemul-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.