From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Matt Mackall <mpm@selenic.com>
Cc: Harvey Harrison <harvey.harrison@gmail.com>,
Ingo Molnar <mingo@elte.hu>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andi Kleen <ak@suse.de>
Subject: Re: [PATCH UPDATE] x86: ignore spurious faults
Date: Thu, 24 Jan 2008 11:21:00 -0800 [thread overview]
Message-ID: <4798E51C.4000209@goop.org> (raw)
In-Reply-To: <1201202046.3897.41.camel@cinder.waste.org>
Matt Mackall wrote:
> There's perhaps an opportunity to do this lazy TLB trick in the mmap
> path as well, where RW mappings are initially mapped as RO so we can
> catch processes dirtying them and then switched to RW. If the mapping is
> shared across threads on multiple cores, we can defer synchronizing the
> TLBs on the others.
>
I think spurious usermode faults are already dealt with.
handle_pte_fault() does essentially the same thing as this patch:
if (ptep_set_access_flags(vma, address, pte, entry, write_access)) {
update_mmu_cache(vma, address, entry);
} else {
/*
* This is needed only for protection faults but the arch code
* is not yet telling us if this is a protection fault or not.
* This still avoids useless tlb flushes for .text page faults
* with threads.
*/
if (write_access)
flush_tlb_page(vma, address);
}
J
next prev parent reply other threads:[~2008-01-24 19:21 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-24 0:05 [PATCH] x86: ignore spurious faults Jeremy Fitzhardinge
2008-01-24 0:18 ` Harvey Harrison
2008-01-24 0:26 ` Jeremy Fitzhardinge
2008-01-24 0:28 ` [PATCH UPDATE] " Jeremy Fitzhardinge
2008-01-24 19:14 ` Matt Mackall
2008-01-24 19:21 ` Jeremy Fitzhardinge [this message]
2008-01-24 23:41 ` Nick Piggin
2008-01-25 0:26 ` Jeremy Fitzhardinge
2008-01-25 7:36 ` Keir Fraser
2008-01-25 8:15 ` Jan Beulich
2008-01-25 8:38 ` Nick Piggin
2008-01-25 9:11 ` Andi Kleen
2008-01-25 9:18 ` Keir Fraser
2008-01-25 9:51 ` Andi Kleen
2008-01-25 10:19 ` Andi Kleen
2008-01-25 13:17 ` Keir Fraser
2008-01-25 9:18 ` Jan Beulich
2008-01-25 15:30 ` Ingo Molnar
2008-01-25 15:54 ` Jeremy Fitzhardinge
2008-01-25 18:08 ` Ingo Molnar
2008-01-25 18:39 ` Jeremy Fitzhardinge
2008-01-24 6:49 ` [PATCH] " Andi Kleen
2008-01-24 7:02 ` Jeremy Fitzhardinge
2008-01-24 7:11 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4798E51C.4000209@goop.org \
--to=jeremy@goop.org \
--cc=ak@suse.de \
--cc=harvey.harrison@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mpm@selenic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.