Re: WARNING: at drivers/ata/libata-core.c:5988 ata_qc_issue()

[Tejun Heo <htejun@gmail.com>]

Mark Lord wrote:
> Tejun Heo wrote:
>> Mark Lord wrote:
>>> Tejun Heo wrote:
>>>> Mark Lord wrote:
>>>>> Tejun,
> ..
>>>> void ata_qc_issue(struct ata_queued_cmd *qc)
>>>> {
>>>>         struct ata_port *ap = qc->ap;
>>>>         struct ata_link *link = qc->dev->link;
>>>>
>>>>         /* Make sure only one non-NCQ command is outstanding.  The
>>>>          * check is skipped for old EH because it reuses active qc to
>>>>          * request ATAPI sense.
>>>>          */
>>> =         WARN_ON(ap->ops->error_handler &&
>>
>> Hmm... Thanks.  Do you have your ->qc_defer set?
> ..
> 
> Err.. no, never heard of it before (now).
> 
> I suppose I should have it set to the default ?

Yeah, just set it to ata_std_qc_defer().

> sata_mv patch 15/14 forthcoming

:-)

-- 
tejun