From: Scott Wood <scottwood-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
To: Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
Cc: linuxppc-dev-mnsaURCQ41sdnm+yROfE0A@public.gmane.org,
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
Subject: Re: [PATCH 3/3] Add device tree compatible aliases to i2c drivers
Date: Thu, 24 Jan 2008 18:33:17 -0600 [thread overview]
Message-ID: <47992E4D.7010500@freescale.com> (raw)
In-Reply-To: <20080125003249.GA30794-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
Olof Johansson wrote:
> For example, for an eeprom I might have: "MCHP,24lc128est",
> "MCHP,24xx128", "24c128". The at24 driver (not in mainline yet :) would
> likely match with "24c128", and it would normally not make sense to have
> to list all specific vendors and models of the device type in question
> in the driver.
It's not really about the vendors of the device, but the namespace it
goes into. If there's really no canonical vendor name, then a plain old
"24c148" might make sense, but that seems like it'd be fairly rare.
> I can't register a board_info for each of the compatible fields without
> changing the way the i2c drivers are registered, since the creation of
> the duplicate entries will start reporting errors.
Even with the current i2c changes that have been flying around the
lists? If so, it should be fixed...
> So it seems that the solution would be to make i2c_board_info take a
> list of names for the device, and each of them has to be matched with
> all drivers, taking the first match.
Agreed.
-Scott
_______________________________________________
i2c mailing list
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
http://lists.lm-sensors.org/mailman/listinfo/i2c
WARNING: multiple messages have this Message-ID (diff)
From: Scott Wood <scottwood@freescale.com>
To: Olof Johansson <olof@lixom.net>
Cc: linuxppc-dev@ozlabs.org, i2c@lm-sensors.org
Subject: Re: [i2c] [PATCH 3/3] Add device tree compatible aliases to i2c drivers
Date: Thu, 24 Jan 2008 18:33:17 -0600 [thread overview]
Message-ID: <47992E4D.7010500@freescale.com> (raw)
In-Reply-To: <20080125003249.GA30794@lixom.net>
Olof Johansson wrote:
> For example, for an eeprom I might have: "MCHP,24lc128est",
> "MCHP,24xx128", "24c128". The at24 driver (not in mainline yet :) would
> likely match with "24c128", and it would normally not make sense to have
> to list all specific vendors and models of the device type in question
> in the driver.
It's not really about the vendors of the device, but the namespace it
goes into. If there's really no canonical vendor name, then a plain old
"24c148" might make sense, but that seems like it'd be fairly rare.
> I can't register a board_info for each of the compatible fields without
> changing the way the i2c drivers are registered, since the creation of
> the duplicate entries will start reporting errors.
Even with the current i2c changes that have been flying around the
lists? If so, it should be fixed...
> So it seems that the solution would be to make i2c_board_info take a
> list of names for the device, and each of them has to be matched with
> all drivers, taking the first match.
Agreed.
-Scott
next prev parent reply other threads:[~2008-01-25 0:33 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-23 2:09 [PATCH 1/3] Rename i2c-mpc to i2c-mpc-drv in preparation for breaking out common code Jon Smirl
2008-01-23 2:09 ` [PATCH 2/3] Convert PowerPC MPC i2c to of_platform_driver from platform_driver Jon Smirl
2008-01-23 3:11 ` Stephen Rothwell
2008-01-23 3:11 ` Stephen Rothwell
2008-01-23 4:18 ` Jon Smirl
2008-01-23 14:31 ` Jon Loeliger
[not found] ` <E1JHgdB-0002zV-F4-CYoMK+44s/E@public.gmane.org>
2008-01-23 14:40 ` Jon Smirl
2008-01-23 14:40 ` Jon Smirl
[not found] ` <20080123020912.31675.48787.stgit-+J+k29bDNxlBDLzU/O5InQ@public.gmane.org>
2008-01-23 2:09 ` [PATCH 3/3] Add device tree compatible aliases to i2c drivers Jon Smirl
2008-01-23 2:09 ` Jon Smirl
2008-01-23 20:18 ` Matt Sealey
2008-01-23 20:30 ` Jon Smirl
2008-02-01 7:32 ` David Gibson
2008-01-25 0:32 ` [i2c] " Olof Johansson
[not found] ` <20080125003249.GA30794-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
2008-01-25 0:33 ` Scott Wood [this message]
2008-01-25 0:33 ` Scott Wood
2008-01-25 0:48 ` Jon Smirl
2008-01-25 0:38 ` Jon Smirl
2008-01-25 0:38 ` [i2c] " Jon Smirl
2008-01-23 2:46 ` [PATCH 1/3] Rename i2c-mpc to i2c-mpc-drv in preparation for breaking out common code Stephen Rothwell
2008-01-23 2:46 ` Stephen Rothwell
[not found] ` <20080123134654.cb5e249d.sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
2008-01-23 2:50 ` Jon Smirl
2008-01-23 2:50 ` Jon Smirl
2008-01-23 3:02 ` Grant Likely
2008-01-23 3:09 ` Jon Smirl
-- strict thread matches above, loose matches on Subject: below --
2008-01-28 14:42 [PATCH 0/3] Implement device tree based i2c module loading on mpc5200 powerpc Jon Smirl
[not found] ` <20080128144202.8410.14647.stgit-+J+k29bDNxlBDLzU/O5InQ@public.gmane.org>
2008-01-28 14:42 ` [PATCH 3/3] Add device tree compatible aliases to i2c drivers Jon Smirl
2008-01-28 14:42 ` Jon Smirl
[not found] ` <20080128144209.8410.37884.stgit-+J+k29bDNxlBDLzU/O5InQ@public.gmane.org>
2008-01-28 17:10 ` Jon Loeliger
2008-01-28 17:10 ` Jon Loeliger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47992E4D.7010500@freescale.com \
--to=scottwood-kzfg59tc24xl57midrcfdg@public.gmane.org \
--cc=i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org \
--cc=linuxppc-dev-mnsaURCQ41sdnm+yROfE0A@public.gmane.org \
--cc=olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.