[Ocfs2-devel] block-count in mkfs.ocfs2

[Ocfs2-devel] block-count in mkfs.ocfs2

[Goldwyn Rodrigues]

Hi,

While making changes to mkfs, I noticed blocks-count is taken as a positional argument (value determined by the position in the command line) instead of an optional argument (parsed by getopts such as --block-count). Is there a particular reason for this?

Moreover, you might have to check on the default values of the mkfs_default_profile. Only the journal size in case of "datafiles" filesystem type seem to be having a default value of 8k.

Regards,

-- 
Goldwyn

[Ocfs2-devel] block-count in mkfs.ocfs2

[Sunil Mushran]

No reason other than mke2fs does the same. Using similar params makes
it easier for everyone. Also, we hardly expect anyone to limit the fs
to smaller than the volume size. AFAIK, it's mainly used in testing
(on/off)line fs resize. :)

It's 8k blocks... meaning 32M, for a 4K blocksize. That is fine if all
the user is doing is hosting datafiles as the db rarely grows the
datafiles... meaning no need for journaling.

Goldwyn Rodrigues wrote:
> Hi,
>
> While making changes to mkfs, I noticed blocks-count is taken as a positional argument (value determined by the position in the command line) instead of an optional argument (parsed by getopts such as --block-count). Is there a particular reason for this?
>
> Moreover, you might have to check on the default values of the mkfs_default_profile. Only the journal size in case of "datafiles" filesystem type seem to be having a default value of 8k.
>
> Regards,
>
>