Re: [PATCH v2 8/9] bfs: remove multiple assignments

[Dmitri Vorobiev <dmitri.vorobiev@gmail.com>]

Tigran Aivazian wrote:
> On Sat, 26 Jan 2008, Dmitri Vorobiev wrote:
>> -    inode->i_mtime = inode->i_atime = inode->i_ctime = CURRENT_TIME_SEC;
>> +    inode->i_mtime = CURRENT_TIME_SEC;
>> +    inode->i_atime = CURRENT_TIME_SEC;
>> +    inode->i_ctime = CURRENT_TIME_SEC;
> 
> multiple assignments like "x = y = z = value;" can potentially
> (depending on the compiler and arch) be faster than "x = value; y =
> value; z=value;"
> 
> I am surprized that this script complains about them as it is a
> perfectly valid thing to do in C.
>

Thanks for your comment.

My goal was to make the driver "checkpatch.pl-clean", and that was the
only reason for this change. I just assumed that what the script, which is
recommended for use to check the kernel coding style, insists upon,
gives an idea of what "the right way" is.

>From the viewpoint of code clarity, it seems to be a matter of personal
opinion whether multiple assignments should be preferred over giving a
separate line to each variable. I personally prefer separated assignments,
but in this particular case I would never touch these lines had the
script not complained about it.
 
> But this is not a "big deal", so I don't mind.
> 

OK. Let's wait for Adrian to pick up these patches and push these into
his tree.

Thanks,

Dmitri