From: Wei Yongjun <yjwei@cn.fujitsu.com>
To: netdev@vger.kernel.org
Cc: lksctp-developers@lists.sourceforge.net,
David Miller <davem@davemloft.net>
Subject: [PATCH] SCTP: Fix miss of report unrecognized HMAC Algorithm parameter
Date: Mon, 28 Jan 2008 08:50:07 +0900 [thread overview]
Message-ID: <479D18AF.7000802@cn.fujitsu.com> (raw)
In-Reply-To: <479A1422.3090304@hp.com>
This patch fix miss of check for report unrecognized HMAC Algorithm
parameter.
When AUTH is disabled, goto fall through path to report unrecognized
parameter, else, just break.
> Wei
>
> Neil Horman wrote:
>> On Wed, Jan 23, 2008 at 09:30:27AM +0900, Wei Yongjun wrote:
>>> This patch fix miss of check for report unrecognized HMAC Algorithm
>>> parameter.
>>> When AUTH is disabled, goto fall through path to report unrecognized
>>> parameter, else, just break.
>>>
>>>
>>
>> Acked-by: Neil Horman <nhorman@tuxdriver.com>
>>
>> Neil
>>
>
> Can you please send this to netdev and CC Dave Miller..
>
> Acked-by: Vlad Yasevich <vladislav.yasevich@hp.com>
>
> -vlad
Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
Acked-by: Vlad Yasevich <vladislav.yasevich@hp.com>
--- a/net/sctp/sm_make_chunk.c 2008-01-21 00:03:25.000000000 -0500
+++ b/net/sctp/sm_make_chunk.c 2008-01-21 02:33:36.000000000 -0500
@@ -2014,7 +2014,7 @@ static sctp_ierror_t sctp_verify_param(c
break;
case SCTP_PARAM_HMAC_ALGO:
- if (!sctp_auth_enable)
+ if (sctp_auth_enable)
break;
/* Fall Through */
fallthrough:
parent reply other threads:[~2008-01-27 23:50 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <479A1422.3090304@hp.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=479D18AF.7000802@cn.fujitsu.com \
--to=yjwei@cn.fujitsu.com \
--cc=davem@davemloft.net \
--cc=lksctp-developers@lists.sourceforge.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.