All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] SCTP: Fix miss of report unrecognized HMAC Algorithm parameter
       [not found]   ` <479A1422.3090304@hp.com>
@ 2008-01-27 23:50     ` Wei Yongjun
  0 siblings, 0 replies; only message in thread
From: Wei Yongjun @ 2008-01-27 23:50 UTC (permalink / raw)
  To: netdev; +Cc: lksctp-developers, David Miller

This patch fix miss of check for report unrecognized HMAC Algorithm 
parameter.
When AUTH is disabled, goto fall through path to report unrecognized 
parameter, else, just break.
> Wei
>
> Neil Horman wrote:
>> On Wed, Jan 23, 2008 at 09:30:27AM +0900, Wei Yongjun wrote:
>>> This patch fix miss of check for report unrecognized HMAC Algorithm 
>>> parameter.
>>> When AUTH is disabled, goto fall through path to report unrecognized 
>>> parameter, else, just break.
>>>
>>>
>>
>> Acked-by: Neil Horman <nhorman@tuxdriver.com>
>>
>> Neil
>>
>
> Can you please send this to netdev and CC Dave Miller..
>
> Acked-by: Vlad Yasevich <vladislav.yasevich@hp.com>
>
> -vlad
Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
Acked-by: Vlad Yasevich <vladislav.yasevich@hp.com>


--- a/net/sctp/sm_make_chunk.c	2008-01-21 00:03:25.000000000 -0500
+++ b/net/sctp/sm_make_chunk.c	2008-01-21 02:33:36.000000000 -0500
@@ -2014,7 +2014,7 @@ static sctp_ierror_t sctp_verify_param(c
 		break;
 
 	case SCTP_PARAM_HMAC_ALGO:
-		if (!sctp_auth_enable)
+		if (sctp_auth_enable)
 			break;
 		/* Fall Through */
 fallthrough:



^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2008-01-27 23:50 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <47968AA3.2060704@cn.fujitsu.com>
     [not found] ` <20080124130551.GA24331@hmsreliant.think-freely.org>
     [not found]   ` <479A1422.3090304@hp.com>
2008-01-27 23:50     ` [PATCH] SCTP: Fix miss of report unrecognized HMAC Algorithm parameter Wei Yongjun

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.