* [PATCH] replace logical- by bit-and in alc_subsystem_id(), sound/pci/hda/patch_realtek.c
@ 2008-01-28 13:35 Roel Kluin
2008-01-28 13:42 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Roel Kluin @ 2008-01-28 13:35 UTC (permalink / raw)
To: tiwai, perex; +Cc: alsa-devel
This was found in linus' git tree, am I right here?
--
replace logical- by bit-and
Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
---
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 1c50278..0a13c53 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -739,7 +739,7 @@ static void alc_subsystem_id(struct hda_codec *codec,
/* check sum */
tmp = 0;
for (i = 1; i < 16; i++) {
- if ((ass >> i) && 1)
+ if ((ass >> i) & 1)
tmp++;
}
if (((ass >> 16) & 0xf) != tmp)
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] replace logical- by bit-and in alc_subsystem_id(), sound/pci/hda/patch_realtek.c
2008-01-28 13:35 [PATCH] replace logical- by bit-and in alc_subsystem_id(), sound/pci/hda/patch_realtek.c Roel Kluin
@ 2008-01-28 13:42 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2008-01-28 13:42 UTC (permalink / raw)
To: Roel Kluin; +Cc: alsa-devel, perex
At Mon, 28 Jan 2008 14:35:39 +0100,
Roel Kluin wrote:
>
> This was found in linus' git tree, am I right here?
> --
> replace logical- by bit-and
>
> Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
Already fixed on ALSA tree.
thanks,
Takashi
> ---
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 1c50278..0a13c53 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -739,7 +739,7 @@ static void alc_subsystem_id(struct hda_codec *codec,
> /* check sum */
> tmp = 0;
> for (i = 1; i < 16; i++) {
> - if ((ass >> i) && 1)
> + if ((ass >> i) & 1)
> tmp++;
> }
> if (((ass >> 16) & 0xf) != tmp)
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-01-28 13:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-01-28 13:35 [PATCH] replace logical- by bit-and in alc_subsystem_id(), sound/pci/hda/patch_realtek.c Roel Kluin
2008-01-28 13:42 ` Takashi Iwai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.