All of lore.kernel.org
 help / color / mirror / Atom feed
From: Valentine Barshak <vbarshak@ru.mvista.com>
To: Josh Boyer <jwboyer@linux.vnet.ibm.com>
Cc: linuxppc-dev@ozlabs.org, sr@denx.de,
	Roel Kluin <12o3l@tiscali.nl>,
	lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][ppc] logical/bitand typo in powerpc/boot/4xx.c
Date: Tue, 29 Jan 2008 17:22:49 +0300	[thread overview]
Message-ID: <479F36B9.2050308@ru.mvista.com> (raw)
In-Reply-To: <20080123191704.2d74073a@zod.rchland.ibm.com>

Josh Boyer wrote:
> On Wed, 23 Jan 2008 23:37:33 +0100
> Roel Kluin <12o3l@tiscali.nl> wrote:
> 
>> logical/bitand typo
>>
>> Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
>> ---
>> diff --git a/arch/powerpc/boot/4xx.c b/arch/powerpc/boot/4xx.c
>> index ebf9e21..dcfb459 100644
>> --- a/arch/powerpc/boot/4xx.c
>> +++ b/arch/powerpc/boot/4xx.c
>> @@ -104,7 +104,7 @@ void ibm4xx_denali_fixup_memsize(void)
>>  	val = DDR_GET_VAL(val, DDR_CS_MAP, DDR_CS_MAP_SHIFT);
>>  	cs = 0;
>>  	while (val) {
>> -		if (val && 0x1)
>> +		if (val & 0x1)
>>  			cs++;
>>  		val = val >> 1;
>>  	}
> 
> Hm, good catch.

Yes, thanks!

Sequoia and Rainier are currently the only boards using denali 
controller and have both chipselects enabled (val = 0x3).
In this case the problem doesn't show up and we still get the right cs 
value.
Thanks,
Valentine.

> 
> Stefan, have you had problems with this code at all?
> 
> josh
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev

WARNING: multiple messages have this Message-ID (diff)
From: Valentine Barshak <vbarshak@ru.mvista.com>
To: Josh Boyer <jwboyer@linux.vnet.ibm.com>
Cc: Roel Kluin <12o3l@tiscali.nl>,
	linuxppc-dev@ozlabs.org, sr@denx.de,
	lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][ppc] logical/bitand typo in powerpc/boot/4xx.c
Date: Tue, 29 Jan 2008 17:22:49 +0300	[thread overview]
Message-ID: <479F36B9.2050308@ru.mvista.com> (raw)
In-Reply-To: <20080123191704.2d74073a@zod.rchland.ibm.com>

Josh Boyer wrote:
> On Wed, 23 Jan 2008 23:37:33 +0100
> Roel Kluin <12o3l@tiscali.nl> wrote:
> 
>> logical/bitand typo
>>
>> Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
>> ---
>> diff --git a/arch/powerpc/boot/4xx.c b/arch/powerpc/boot/4xx.c
>> index ebf9e21..dcfb459 100644
>> --- a/arch/powerpc/boot/4xx.c
>> +++ b/arch/powerpc/boot/4xx.c
>> @@ -104,7 +104,7 @@ void ibm4xx_denali_fixup_memsize(void)
>>  	val = DDR_GET_VAL(val, DDR_CS_MAP, DDR_CS_MAP_SHIFT);
>>  	cs = 0;
>>  	while (val) {
>> -		if (val && 0x1)
>> +		if (val & 0x1)
>>  			cs++;
>>  		val = val >> 1;
>>  	}
> 
> Hm, good catch.

Yes, thanks!

Sequoia and Rainier are currently the only boards using denali 
controller and have both chipselects enabled (val = 0x3).
In this case the problem doesn't show up and we still get the right cs 
value.
Thanks,
Valentine.

> 
> Stefan, have you had problems with this code at all?
> 
> josh
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev


  parent reply	other threads:[~2008-01-29 14:24 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-23 22:37 [PATCH][ppc] logical/bitand typo in powerpc/boot/4xx.c Roel Kluin
2008-01-23 23:05 ` Joe Perches
2008-01-23 23:05   ` Joe Perches
2008-01-24  0:18   ` Roel Kluin
2008-01-24  0:18     ` Roel Kluin
2008-01-24  0:39     ` Joe Perches
2008-01-24  0:39       ` Joe Perches
2008-01-29 10:55     ` Andy Whitcroft
2008-01-29 10:55       ` Andy Whitcroft
2008-01-29 13:34       ` Roel Kluin
2008-01-29 13:34         ` Roel Kluin
2008-01-24  1:17 ` Josh Boyer
2008-01-24  1:17   ` Josh Boyer
2008-01-26 13:37   ` Stefan Roese
2008-01-26 13:37     ` Stefan Roese
2008-01-29 14:22   ` Valentine Barshak [this message]
2008-01-29 14:22     ` Valentine Barshak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=479F36B9.2050308@ru.mvista.com \
    --to=vbarshak@ru.mvista.com \
    --cc=12o3l@tiscali.nl \
    --cc=jwboyer@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=sr@denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.