From: Sean MacLennan <smaclennan@pikatech.com>
To: linuxppc-dev@ozlabs.org
Subject: ndfc ecc byte order
Date: Wed, 30 Jan 2008 14:52:28 -0500 [thread overview]
Message-ID: <47A0D57C.1000104@pikatech.com> (raw)
There seems to be a byte order conflict between the u-boot and Linux
ndfc drivers.
u-boot has the following:
/* The NDFC uses Smart Media (SMC) bytes order*/
ecc_code[0] = p[2];
ecc_code[1] = p[1];
ecc_code[2] = p[3];
the kernel has:
ecc_code[0] = p[1];
ecc_code[1] = p[2];
ecc_code[2] = p[3];
I think u-boot has it right since u-boot and kernel software calculated
ECCs agree. Anybody know a reason *not* to switch to the SMC byte order?
Note that the kernel version will work if you are reading/writing from
the kernel since they agree on the wrong ECC :p
Cheers,
Sean
next reply other threads:[~2008-01-30 19:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-30 19:52 Sean MacLennan [this message]
2008-01-30 21:01 ` ndfc ecc byte order Stefan Roese
2008-02-01 8:12 ` Stefan Roese
2008-02-01 8:34 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47A0D57C.1000104@pikatech.com \
--to=smaclennan@pikatech.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.