[RFC] add kernel-module-loop to roofs for collie and tosa

[RFC] add kernel-module-loop to roofs for collie and tosa

[Junqian Gordon Xu]

altboot-console-image needs loopback file support either in the kernel 
or as kernel module. CONFIG_BLK_DEV_LOOP=m were set for both collie and 
tosa. Other Z deviced has loopback file support built into the kernel. 
I would propose the following change [both dev and stable] to pack 
kernel-module-loop into the default rootfs for collie and tosa; and bump 
PR for task-base.

============================================================
--- conf/machine/collie.conf	c23a85835bc13ac978f36742cfc8ccf5880e0ec8
+++ conf/machine/collie.conf	062e7d70c35cf3f4db0e10e8b9f254fd47e39952
@@ -14,5 +14,7 @@ IMAGE_FSTYPES ?= "jffs2 tar.gz"
  IMAGE_LINGUAS = ""
  IMAGE_FSTYPES ?= "jffs2 tar.gz"

+MACHINE_EXTRA_RRECOMMENDS += "kernel-module-loop"
+
  ROOT_FLASH_SIZE = "14"
  # actually 14680064, see EXTRA_IMAGECMD above
============================================================
--- conf/machine/tosa.conf	bdda7deb7ee9f2d950ee255097efcdfa1cf7a39a
+++ conf/machine/tosa.conf	94e6eda28ba66d57c2ef49c6c11c78bf0c311349
@@ -7,6 +7,6 @@ IMAGE_FSTYPES ?= "jffs2"
  IMAGE_FSTYPES ?= "jffs2"

  # wlan-ng Modules
-MACHINE_EXTRA_RRECOMMENDS += "wlan-ng-modules-usb"
+MACHINE_EXTRA_RRECOMMENDS += "wlan-ng-modules-usb kernel-module-loop"

  ROOT_FLASH_SIZE = "28"


Regards
Gordon

Re: [Angstrom-devel] [RFC] add kernel-module-loop to roofs for collie and tosa

[Marcin Juszkiewicz]

Dnia Wednesday, 30 of January 2008, Junqian Gordon Xu napisał:
> altboot-console-image needs loopback file support either in the kernel
> or as kernel module. 

It is not 'altboot-console-image' which needs it but altboot. 

> CONFIG_BLK_DEV_LOOP=m were set for both collie and tosa. Other Z deviced
> has loopback file support built into the kernel. 

Probably not for long as kernel size increase with each version ;(

> I would propose the following change [both dev and stable] to pack 
> kernel-module-loop into the default rootfs for collie and tosa; and
> bump PR for task-base.

As altboot needs it then it has to be added as RRECOMMENDS to altboot 
recipe rather.

-- 
JID: hrw-jabber.org
OpenEmbedded developer/consultant

            We're here to give you a computer, not a religion.
            		-- Bob Pariseau, at the introduction of the Amiga

Re: [Angstrom-devel] [RFC] add kernel-module-loop to roofs for collie and tosa

[Junqian Gordon Xu]

On 01/30/2008 05:23 AM, Marcin Juszkiewicz wrote:
> Dnia Wednesday, 30 of January 2008, Junqian Gordon Xu napisał:
>> altboot-console-image needs loopback file support either in the kernel
>> or as kernel module. 
> 
> It is not 'altboot-console-image' which needs it but altboot. 

You are right, but practically it's not nice to have users to go find 
kernel-module-loop before they can install roofs as a loopback image at 
SD/CF. For tosa, the typical case is to install altboot-console-image 
first then use altboot to install another image.

>> CONFIG_BLK_DEV_LOOP=m were set for both collie and tosa. Other Z deviced
>> has loopback file support built into the kernel. 
> 
> Probably not for long as kernel size increase with each version ;(

We can set it as module for all devices, sooner or later.

>> I would propose the following change [both dev and stable] to pack 
>> kernel-module-loop into the default rootfs for collie and tosa; and
>> bump PR for task-base.
> 
> As altboot needs it then it has to be added as RRECOMMENDS to altboot 
> recipe rather.

The point is to have it available with altboot at the very beginning. 
Although it's not techinically RDEPENDS, should we set it as RDEPENDS to 
altboot recipe?

Regards
Gordon

Re: [RFC] add kernel-module-loop to roofs for collie and tosa

[Thomas Kunze]

Junqian Gordon Xu wrote:
> altboot-console-image needs loopback file support either in the kernel 
> or as kernel module. CONFIG_BLK_DEV_LOOP=m were set for both collie and 
> tosa. Other Z deviced has loopback file support built into the kernel. 
> I would propose the following change [both dev and stable] to pack 
> kernel-module-loop into the default rootfs for collie and tosa; and bump 
> PR for task-base.
>
> ============================================================
> --- conf/machine/collie.conf	c23a85835bc13ac978f36742cfc8ccf5880e0ec8
> +++ conf/machine/collie.conf	062e7d70c35cf3f4db0e10e8b9f254fd47e39952
> @@ -14,5 +14,7 @@ IMAGE_FSTYPES ?= "jffs2 tar.gz"
>   IMAGE_LINGUAS = ""
>   IMAGE_FSTYPES ?= "jffs2 tar.gz"
>
> +MACHINE_EXTRA_RRECOMMENDS += "kernel-module-loop"
> +
>   ROOT_FLASH_SIZE = "14"
>   # actually 14680064, see EXTRA_IMAGECMD above
> ============================================================
> --- conf/machine/tosa.conf	bdda7deb7ee9f2d950ee255097efcdfa1cf7a39a
> +++ conf/machine/tosa.conf	94e6eda28ba66d57c2ef49c6c11c78bf0c311349
> @@ -7,6 +7,6 @@ IMAGE_FSTYPES ?= "jffs2"
>   IMAGE_FSTYPES ?= "jffs2"
>
>   # wlan-ng Modules
> -MACHINE_EXTRA_RRECOMMENDS += "wlan-ng-modules-usb"
> +MACHINE_EXTRA_RRECOMMENDS += "wlan-ng-modules-usb kernel-module-loop"
>
>   ROOT_FLASH_SIZE = "28"
>
>
> Regards
> Gordon
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>   
Wouldn't it be better do make altboot depend on kernel-modules-loop?

Re: [Angstrom-devel] [RFC] add kernel-module-loop to roofs for collie and tosa

[Marcin Juszkiewicz]

Dnia Wednesday, 30 of January 2008, Junqian Gordon Xu napisał:
> On 01/30/2008 05:23 AM, Marcin Juszkiewicz wrote:
> > Dnia Wednesday, 30 of January 2008, Junqian Gordon Xu napisał:
> >> altboot-console-image needs loopback file support either in the
> >> kernel or as kernel module.
> >
> > It is not 'altboot-console-image' which needs it but altboot.
>
> You are right, but practically it's not nice to have users to go find
> kernel-module-loop before they can install roofs as a loopback image at
> SD/CF. For tosa, the typical case is to install altboot-console-image
> first then use altboot to install another image.

Users does not have to go and find it. OE will take care of it and 
installing altboot into image will also adds kernel-module-loop package. 
Thats how dependencies works.

> >> I would propose the following change [both dev and stable] to pack
> >> kernel-module-loop into the default rootfs for collie and tosa; and
> >> bump PR for task-base.
> >
> > As altboot needs it then it has to be added as RRECOMMENDS to altboot
> > recipe rather.
>
> The point is to have it available with altboot at the very beginning.
> Although it's not techinically RDEPENDS, should we set it as RDEPENDS
> to altboot recipe?

RRECOMMENDS is proper for kernel modules as it does not break if package 
is not available (which is a case when loop is in kernel not module).

-- 
JID: hrw-jabber.org
OpenEmbedded developer/consultant

                            It is your destiny.
                            		-- Darth Vader

Re: [Angstrom-devel] [RFC] add kernel-module-loop to roofs for collie and tosa

[Junqian Gordon Xu]

On 01/30/2008 10:11 AM, Marcin Juszkiewicz wrote:
> Users does not have to go and find it. OE will take care of it and 
> installing altboot into image will also adds kernel-module-loop package. 
> Thats how dependencies works.
> 
> 
> RRECOMMENDS is proper for kernel modules as it does not break if package 
> is not available (which is a case when loop is in kernel not module).
> 

Thanks. If CoreDump doesn't object, I will add kernel-module-loop as an 
RRECOMMENDS to altboot recipies.

Regards
Gordon