All of lore.kernel.org
 help / color / mirror / Atom feed
* [lm-sensors] PATCH: sensors-detect: run chip_special_cases()
@ 2008-02-11 13:20 Hans de Goede
  2008-02-12  7:56 ` Jean Delvare
  0 siblings, 1 reply; 2+ messages in thread
From: Hans de Goede @ 2008-02-11 13:20 UTC (permalink / raw)
  To: lm-sensors

[-- Attachment #1: Type: text/plain, Size: 422 bytes --]

Hi All,

The attached patch modifies sensors-detect to run chip_special_cases() earlier 
so that the special chips get added to the modules_supported list.

Without this sensors-detect would wrongly complain that fscher is not a sensor 
chip when run on a system with an fscher chip and the fscher driver already loaded.

If I don't get any objections I will be committing this to svn in a couple of days.

Regards,

Hans

[-- Attachment #2: lm_sensors-3.0.1-sensors-detect-special-chips.patch --]
[-- Type: text/x-patch, Size: 888 bytes --]

diff -up lm_sensors-3.0.1/prog/detect/sensors-detect~ lm_sensors-3.0.1/prog/detect/sensors-detect
--- lm_sensors-3.0.1/prog/detect/sensors-detect~	2008-02-11 13:59:25.000000000 +0100
+++ lm_sensors-3.0.1/prog/detect/sensors-detect	2008-02-11 13:59:25.000000000 +0100
@@ -5677,6 +5677,9 @@ sub main
   initialize_conf;
   initialize_proc_pci;
   initialize_modules_list;
+  # make sure any special case chips are added to the chip_ids list before
+  # making the support modules list
+  chip_special_cases();
   initialize_modules_supported;
   initialize_cpu_list();
 
@@ -5740,9 +5744,6 @@ sub main
     print "\n";
   }
 
-  # Before looking for chips, make sure any special case chips are
-  # added to the chip_ids list
-  chip_special_cases();
   $i2c_addresses_to_scan = i2c_addresses_to_scan();
 
   print "We are now going to do the I2C/SMBus adapter probings. Some chips may\n",

[-- Attachment #3: Type: text/plain, Size: 153 bytes --]

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [lm-sensors] PATCH: sensors-detect: run chip_special_cases()
  2008-02-11 13:20 [lm-sensors] PATCH: sensors-detect: run chip_special_cases() Hans de Goede
@ 2008-02-12  7:56 ` Jean Delvare
  0 siblings, 0 replies; 2+ messages in thread
From: Jean Delvare @ 2008-02-12  7:56 UTC (permalink / raw)
  To: lm-sensors

Hi Hans,

On Mon, 11 Feb 2008 14:20:09 +0100, Hans de Goede wrote:
> The attached patch modifies sensors-detect to run chip_special_cases() earlier 
> so that the special chips get added to the modules_supported list.
> 
> Without this sensors-detect would wrongly complain that fscher is not a sensor 
> chip when run on a system with an fscher chip and the fscher driver already loaded.
> 
> If I don't get any objections I will be committing this to svn in a couple of days.

Good catch, please commit. Don't forget to commit to both active
branches of lm-sensors.

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-02-12  7:56 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-02-11 13:20 [lm-sensors] PATCH: sensors-detect: run chip_special_cases() Hans de Goede
2008-02-12  7:56 ` Jean Delvare

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.