From: Tejun Heo <htejun@gmail.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Jeff Garzik <jeff@garzik.org>,
IDE/ATA development list <linux-ide@vger.kernel.org>,
Mark Lord <liml@rtr.ca>, Alan Cox <alan@lxorguk.ukuu.org.uk>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH #upstream] libata: implement libata.force module parameter
Date: Tue, 12 Feb 2008 09:24:12 +0900 [thread overview]
Message-ID: <47B0E72C.3050305@gmail.com> (raw)
In-Reply-To: <47ABD817.2020903@gmail.com>
Tejun Heo wrote:
> Sam Ravnborg wrote:
>> I have lost the actual patch.
>> But what you see is what happens when you mix const and non-const data
>> in the same section.
>>
>> Look for use of __initdata for const data and replace it with __initconst.
>>
>> And modpost cannot warn about it as gcc errors out before we look at the
>> .o file with modpost.
>
> OIC, thanks. Hmmm... in init.h, I see __{dev|cpu|mem}initconst but no
> __initconst. The data structure in question is used from module init
> function tagged properly with __init. What should be done here?
PING.
--
tejun
next prev parent reply other threads:[~2008-02-12 0:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-01 15:14 [PATCH #upstream] libata: implement libata.force module parameter Tejun Heo
2008-02-01 17:28 ` Jeff Garzik
2008-02-01 17:46 ` Bartlomiej Zolnierkiewicz
2008-02-01 18:36 ` Sam Ravnborg
2008-02-08 4:18 ` Tejun Heo
2008-02-12 0:24 ` Tejun Heo [this message]
2008-02-12 9:07 ` Tejun Heo
2008-02-12 9:07 ` Tejun Heo
2008-02-13 0:15 ` Tejun Heo
2008-02-13 16:24 ` Mark Lord
2008-02-14 0:17 ` Tejun Heo
2008-02-14 16:24 ` Mark Lord
2008-02-20 17:13 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47B0E72C.3050305@gmail.com \
--to=htejun@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jeff@garzik.org \
--cc=liml@rtr.ca \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.