Re: [Xenomai-core] [patch 2/4] RTDM support for select-like service.

[Jan Kiszka <jan.kiszka@domain.hid>]

Jan Kiszka wrote:
> Gilles Chanteperdrix wrote:
>> I also have the choice of defining the service needed
>> (rt_dev_select_bind) as a callback in the posix module, the RTDM module
>> setting this callback when loaded (like what the rtcap module does with
>> rtnet). But I wanted something simple, so I aimed at Kconfig stuff.
>>
> 
> If you can live with the callback being NULL, you could also perfectly
> wrap some ifdef CONFIG_...RTDM[_MODULE] around the current invocations.
> Then you don't need the dependency above. I think I have to look at the
> code...
> 

I understood the core of your problem meanwhile. Here is a better
suggestion:

Index: ksrc/skins/posix/Kconfig
===================================================================
--- ksrc/skins/posix/Kconfig	(Revision 3499)
+++ ksrc/skins/posix/Kconfig	(Arbeitskopie)
@@ -47,9 +47,15 @@ config XENO_OPT_POSIX_INTR
 	RTDM skin is the preferred way of implementing drivers), leave this
 	option unselected.
 
+if XENO_SKIN_RTDM = m && XENO_SKIN_RTDM != XENO_SKIN_POSIX
+	comment "Note: Select support only available if the POSIX skin is built"
+	comment "as module or the RTDM skin is built into the kernel as well."
+endif
+
 config XENO_OPT_POSIX_SELECT
 	bool "Select syscall"
 	select XENO_OPT_SELECT
+	depends on XENO_SKIN_RTDM != m || XENO_SKIN_RTDM = XENO_SKIN_POSIX
 	help
 
 	This option allows applications using the Xenomai POSIX skin in
@@ -65,10 +71,3 @@ config XENO_OPT_DEBUG_POSIX
 	cleaned up POSIX objects it detects on process termination.
 
 endif
-
-if XENO_OPT_POSIX_SELECT && XENO_SKIN_POSIX = y && XENO_SKIN_RTDM = m
-	comment "This configuration will not work ! If you enable the POSIX"
-	comment "select syscall while the POSIX skin is built-in the kernel,"
-	comment "you have to compile the POSIX skin as a module or the RTDM"
-	comment "skin built-in the kernel."
-endif

-- 
Siemens AG, Corporate Technology, CT SE 2
Corporate Competence Center Embedded Linux