* [patch] kexec: Use target linker for purgatory
@ 2007-12-21 0:16 Geoff Levand
2007-12-21 1:28 ` Jeremy Kerr
2008-02-12 17:16 ` Geoff Levand
0 siblings, 2 replies; 7+ messages in thread
From: Geoff Levand @ 2007-12-21 0:16 UTC (permalink / raw)
To: kexec; +Cc: Jeremy Kerr
From: Geoff Levand <geoffrey.levand@am.sony.com>
Pugatory files need to be linked with the target linker,
not the build linker.
Signed-off-by: Geoff Levand <geoffrey.levand@am.sony.com>
---
diff --git a/purgatory/Makefile b/purgatory/Makefile
index a543cdb..e7d2f15 100644
--- a/purgatory/Makefile
+++ b/purgatory/Makefile
@@ -42,7 +42,7 @@ $(PURGATORY): LDFLAGS+=--no-undefined -nostartfiles -nostdlib -nodefaultlibs \
$(PURGATORY): $(PURGATORY_OBJS)
$(MKDIR) -p $(@D)
- $(LD) $(LDFLAGS) -o $@ $^
+ $(CC) $(LDFLAGS) -o $@ $^
# $(LD) $(LDFLAGS) $(EXTRA_LDFLAGS) --no-undefined -e purgatory_start -r -o $@ $(PURGATORY_OBJS) $(UTIL_LIB)
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [patch] kexec: Use target linker for purgatory
2007-12-21 0:16 [patch] kexec: Use target linker for purgatory Geoff Levand
@ 2007-12-21 1:28 ` Jeremy Kerr
2007-12-21 1:43 ` Geoff Levand
2008-02-12 17:16 ` Geoff Levand
1 sibling, 1 reply; 7+ messages in thread
From: Jeremy Kerr @ 2007-12-21 1:28 UTC (permalink / raw)
To: Geoff Levand; +Cc: kexec
Geoff,
> Pugatory files need to be linked with the target linker,
> not the build linker.
>
> $(MKDIR) -p $(@D)
> - $(LD) $(LDFLAGS) -o $@ $^
> + $(CC) $(LDFLAGS) -o $@ $^
Shouldn't that be $(TARGET_CC) then?
Cheers,
Jeremy
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [patch] kexec: Use target linker for purgatory
2007-12-21 1:28 ` Jeremy Kerr
@ 2007-12-21 1:43 ` Geoff Levand
2007-12-21 1:49 ` Jeremy Kerr
0 siblings, 1 reply; 7+ messages in thread
From: Geoff Levand @ 2007-12-21 1:43 UTC (permalink / raw)
To: Jeremy Kerr; +Cc: kexec
On 12/20/2007 05:28 PM, Jeremy Kerr wrote:
> Geoff,
>
>> Pugatory files need to be linked with the target linker,
>> not the build linker.
>>
>> $(MKDIR) -p $(@D)
>> - $(LD) $(LDFLAGS) -o $@ $^
>> + $(CC) $(LDFLAGS) -o $@ $^
>
> Shouldn't that be $(TARGET_CC) then?
It follows the convention in that makefile. There is this:
$(PURGATORY): CC=$(TARGET_CC)
-Geoff
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [patch] kexec: Use target linker for purgatory
2007-12-21 1:43 ` Geoff Levand
@ 2007-12-21 1:49 ` Jeremy Kerr
0 siblings, 0 replies; 7+ messages in thread
From: Jeremy Kerr @ 2007-12-21 1:49 UTC (permalink / raw)
To: kexec; +Cc: Geoff Levand
Geoff,
> It follows the convention in that makefile. There is this:
Sorry, brain-snap on my behalf :)
Acked-by: Jeremy Kerr <jk@ozlabs.org>
Cheers,
Jeremy
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [patch] kexec: Use target linker for purgatory
2007-12-21 0:16 [patch] kexec: Use target linker for purgatory Geoff Levand
2007-12-21 1:28 ` Jeremy Kerr
@ 2008-02-12 17:16 ` Geoff Levand
1 sibling, 0 replies; 7+ messages in thread
From: Geoff Levand @ 2008-02-12 17:16 UTC (permalink / raw)
To: kexec; +Cc: Jeremy Kerr
Hello...
This needs to be merged.
On 12/20/2007 04:16 PM, Geoff Levand wrote:
> From: Geoff Levand <geoffrey.levand@am.sony.com>
>
> Pugatory files need to be linked with the target linker,
> not the build linker.
>
> Signed-off-by: Geoff Levand <geoffrey.levand@am.sony.com>
> ---
> diff --git a/purgatory/Makefile b/purgatory/Makefile
> index a543cdb..e7d2f15 100644
> --- a/purgatory/Makefile
> +++ b/purgatory/Makefile
> @@ -42,7 +42,7 @@ $(PURGATORY): LDFLAGS+=--no-undefined -nostartfiles -nostdlib -nodefaultlibs \
>
> $(PURGATORY): $(PURGATORY_OBJS)
> $(MKDIR) -p $(@D)
> - $(LD) $(LDFLAGS) -o $@ $^
> + $(CC) $(LDFLAGS) -o $@ $^
>
> # $(LD) $(LDFLAGS) $(EXTRA_LDFLAGS) --no-undefined -e purgatory_start -r -o $@ $(PURGATORY_OBJS) $(UTIL_LIB)
>
>
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 7+ messages in thread
* [patch] kexec: Use target linker for purgatory
@ 2008-02-15 5:27 Geoff Levand
2008-02-19 6:26 ` Simon Horman
0 siblings, 1 reply; 7+ messages in thread
From: Geoff Levand @ 2008-02-15 5:27 UTC (permalink / raw)
To: Simon Horman; +Cc: kexec, Jeremy Kerr
From: Geoff Levand <geoffrey.levand@am.sony.com>
Pugatory files need to be linked with the target linker,
not the build linker.
Signed-off-by: Geoff Levand <geoffrey.levand@am.sony.com>
---
Hi,
This is a resend from last December. It fixes a cross compile
build error. Please appy.
-Geoff
diff --git a/purgatory/Makefile b/purgatory/Makefile
index a543cdb..e7d2f15 100644
--- a/purgatory/Makefile
+++ b/purgatory/Makefile
@@ -42,7 +42,7 @@ $(PURGATORY): LDFLAGS+=--no-undefined -nostartfiles -nostdlib -nodefaultlibs \
$(PURGATORY): $(PURGATORY_OBJS)
$(MKDIR) -p $(@D)
- $(LD) $(LDFLAGS) -o $@ $^
+ $(CC) $(LDFLAGS) -o $@ $^
# $(LD) $(LDFLAGS) $(EXTRA_LDFLAGS) --no-undefined -e purgatory_start -r -o $@ $(PURGATORY_OBJS) $(UTIL_LIB)
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [patch] kexec: Use target linker for purgatory
2008-02-15 5:27 Geoff Levand
@ 2008-02-19 6:26 ` Simon Horman
0 siblings, 0 replies; 7+ messages in thread
From: Simon Horman @ 2008-02-19 6:26 UTC (permalink / raw)
To: Geoff Levand; +Cc: kexec, Jeremy Kerr
On Thu, Feb 14, 2008 at 09:27:19PM -0800, Geoff Levand wrote:
>
> Pugatory files need to be linked with the target linker,
> not the build linker.
Thanks Geoff, applied.
--
Horms
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2008-02-19 6:26 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-12-21 0:16 [patch] kexec: Use target linker for purgatory Geoff Levand
2007-12-21 1:28 ` Jeremy Kerr
2007-12-21 1:43 ` Geoff Levand
2007-12-21 1:49 ` Jeremy Kerr
2008-02-12 17:16 ` Geoff Levand
-- strict thread matches above, loose matches on Subject: below --
2008-02-15 5:27 Geoff Levand
2008-02-19 6:26 ` Simon Horman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.