Re: [PATCH] hid, 2.6.23 - add support for new macbook and apple aluminum keyboard "fn" key

["Tobias Müller" <Tobias_Mueller@twam.info>]

[-- Attachment #1: Type: text/plain, Size: 1412 bytes --]

Jiri Kosina schrieb:
> Some part of the patch is already in 2.6.25-rc1 -- please see commit 
> a45d82d19a6c2a717bcc33cff243199b77fa0082, which adds support for Apple 
> Aluminium keyboards. So the patch would need some changes that it would 
> apply on top of current tree.
It seems there is almost everything implemented except for some product ids.

> Also, Tobias (added to CC) seems to be currently working on adding support 
> for a subset of keyboards that this patch adds. Tobias -- it seems like 
> this patch is handling a superset of what your patch does, right?
Yes

> It would be great if you could put this all together into one condensated 
> patch which I could merge into my tree.
I'm working on that, but I found a problem in the new 2.6.25-rc1 code.

Until 2.6.24 hidinput_apple_event which handles the apple specials was called by
hidinput_hid_event and if hidinput_apple_event changed some code, hidinput_hid_event
returned and didn't send any events.

In 2.6.25 hidinput_apple_event is called in hidinput_event_quirks which is called by 
hidinput_hid_event. But if hidinput_event_quirks sent events, hidinput_hid_event doesn't
know of this and send the events too! So if I press some keys on my keyboard, there are
2 keycodes sent.

This seems to be a greater change in 2.6.25 and I don't want to change this, because I think
someone made this change for some good reason.

Regards
  Tobias

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/x-pkcs7-signature, Size: 3389 bytes --]