All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Tobias Müller" <Tobias_Mueller@twam.info>
To: Jiri Kosina <jkosina@suse.cz>, linux-input@vger.kernel.org
Subject: Re: [PATCH] hid, 2.6.23 - add support for new macbook and apple aluminum keyboard "fn" key
Date: Fri, 14 Mar 2008 17:41:15 +0100	[thread overview]
Message-ID: <47DAAAAB.8000703@twam.info> (raw)
In-Reply-To: <Pine.LNX.4.64.0802131705250.30955@jikos.suse.cz>

[-- Attachment #1: Type: text/plain, Size: 1304 bytes --]

Hi!

I 
just 
tested 
the 
rc5 
on 
my 
pc 
and 
macbook 
and 
found 
a 
small 
mistake:

diff 
--git 
a/drivers/hid/usbhid/hid-quirks.c 
b/drivers/hid/usbhid/hid-quirks.c
index 
e6d05f6..de8c5a9 
100644
--- 
a/drivers/hid/usbhid/hid-quirks.c
+++ 
b/drivers/hid/usbhid/hid-quirks.c
@@ 
-624,7 
+624,7 
@@ 
static 
const 
struct 
hid_blacklist 
{
         { USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_ALU_ISO, HID_QUIRK_APPLE_HAS_FN | HID_QUIRK_APPLE_ISO_KEYBOARD },
         { USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_ALU_JIS, HID_QUIRK_APPLE_HAS_FN },
         { USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_GEYSER4_HF_ANSI, HID_QUIRK_APPLE_HAS_FN | HID_QUIRK_IGNORE_MOUSE },
- 
       { USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_GEYSER4_HF_ISO, HID_QUIRK_APPLE_HAS_FN | HID_QUIRK_IGNORE_MOUSE | HID_QUIRK_APPLE_ISO_KEYBOARD },
+ 
       { USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_GEYSER4_HF_ISO, HID_QUIRK_APPLE_HAS_FN | HID_QUIRK_IGNORE_MOUSE },
         { USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_GEYSER4_HF_JIS, HID_QUIRK_APPLE_HAS_FN | HID_QUIRK_IGNORE_MOUSE },
         { USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_ALU_WIRELESS_ANSI, HID_QUIRK_APPLE_HAS_FN },
         { USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_ALU_WIRELESS_ISO, HID_QUIRK_APPLE_HAS_FN | HID_QUIRK_APPLE_ISO_KEYBOARD },

Regards
   Tobias

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/x-pkcs7-signature, Size: 3389 bytes --]

  reply	other threads:[~2008-03-14 16:41 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-12 19:36 [PATCH] hid, 2.6.23 - add support for new macbook and apple aluminum keyboard "fn" key Chris Nolan
2008-02-12 20:48 ` Jiri Kosina
2008-02-13 12:44   ` Tobias Müller
2008-02-13 12:57     ` Jiri Kosina
2008-02-13 15:49       ` Tobias Müller
2008-02-13 16:06         ` Jiri Kosina
2008-03-14 16:41           ` Tobias Müller [this message]
2008-03-14 16:52             ` Jiri Kosina
2008-03-14 17:03               ` Tobias Müller
2008-03-14 22:26                 ` Jiri Kosina
2008-03-14 20:52               ` Tobias Müller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47DAAAAB.8000703@twam.info \
    --to=tobias_mueller@twam.info \
    --cc=jkosina@suse.cz \
    --cc=linux-input@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.