Valgrind warnings in libnetfilter_queue about pointers to uninitialsed bytes

Valgrind warnings in libnetfilter_queue about pointers to uninitialsed bytes

[Arthur Ulfeldt]

Valgrind is reporting uninitialised bytes at the pointer returned by nfq_open().
libnetfilter_queue version 1.1.0.

/* initialize the netfilter queue */
if (( _queue.nfq_h = nfq_open()) == NULL ) return perrlog( "nfq_open" );
 
/* Unbind any existing queue handlers */
/* In > 2.6.22, EINVAL is returned if the queue handler isn't register.  So
   we just ignore it. */
if ( nfq_unbind_pf( _queue.nfq_h, PF_INET ) < 0 && errno != EINVAL ) return perrlog( "nfq_unbind_pf" );
    ==20443== Syscall param ! points to uninitialised byte(s)
    ==20443==    at 0x4030B4E: sendmsg (in /lib/tls/libpthread-0.60.so)
    ==20443==    by 0x28659EF4: (within /usr/lib/libnetfilter_queue.so.1.1.0)
    ==20443==    by 0x2865A167: nfq_unbind_pf (in /usr/lib/libnetfilter_queue.so.1.1.0)

/* Bind queue */
if ( nfq_bind_pf( _queue.nfq_h, PF_INET ) < 0 ) return perrlog( "nfq_bind_pf" );
    ==20443== Syscall param ! points to uninitialised byte(s)
    ==20443==    at 0x4030B4E: sendmsg (in /lib/tls/libpthread-0.60.so)
    ==20443==    by 0x28659EF4: (within /usr/lib/libnetfilter_queue.so.1.1.0)
    ==20443==    by 0x2865A1FA: nfq_create_queue (in /usr/lib/libnetfilter_queue.so.1.1.0)

/* Bind the socket to a queue */
   if (( _queue.nfq_qh = nfq_create_queue( _queue.nfq_h,  0, &_nf_callback, NULL )) == NULL ) {
      return perrlog( "nfq_create_queue" );
   }
        
....
/* Cleanup */    
/* close the queue handler */
if (( _queue.nfq_qh != NULL ) && ( nfq_destroy_queue( _queue.nfq_qh ) < 0 )) {
    perrlog( "nfq_destroy_queue" );
}
    ==20443== Syscall param <DD><DD><DD><DD><DD><DD><DD><DD><DD><DD><DD><DD><DD><DD>
    <DD><DD><DD><DD><DD><DD><DD><DD><DD><DD><DD><DD><DD><DD><DD><DD><DD><DD><DD><DD>
    <DD><DD><DD><DD><DD><DD> points to uninitialised byte(s)
    ==20443==    at 0x4030B4E: sendmsg (in /lib/tls/libpthread-0.60.so)
    ==20443==    by 0x28659EF4: (within /usr/lib/libnetfilter_queue.so.1.1.0)
    ==20443==    by 0x2865A26E: nfq_destroy_queue (in /usr/lib/libnetfilter_queue.so
    .1.1.0)

Re: Valgrind warnings in libnetfilter_queue about pointers to uninitialsed bytes

[Pablo Neira Ayuso]

Arthur Ulfeldt wrote:
> Valgrind is reporting uninitialised bytes at the pointer returned by nfq_open().
> libnetfilter_queue version 1.1.0.

I'd appreciate a patch for this since I won't be able to fix it along
this week.

-- 
"Los honestos son inadaptados sociales" -- Les Luthiers