Re: [RFC] [PATCH 4/4] Add soft limit documentation

[Balbir Singh <balbir@linux.vnet.ibm.com>]

Randy Dunlap wrote:
> On Wed, 13 Feb 2008 20:42:56 +0530 Balbir Singh wrote:
> 
>> Add documentation for the soft limit feature.
>>
>> Signed-off-by: Balbir Singh <balbir@linux.vnet.ibm.com>
>> ---
>>
>>  Documentation/controllers/memory.txt |   16 ++++++++++++++++
>>  1 file changed, 16 insertions(+)
>>
>> diff -puN Documentation/controllers/memory.txt~memory-controller-add-soft-limit-documentation Documentation/controllers/memory.txt
>> --- linux-2.6.24/Documentation/controllers/memory.txt~memory-controller-add-soft-limit-documentation	2008-02-13 18:45:40.000000000 +0530
>> +++ linux-2.6.24-balbir/Documentation/controllers/memory.txt	2008-02-13 18:49:58.000000000 +0530
>> @@ -201,6 +201,22 @@ The memory.force_empty gives an interfac
>>  
>>  will drop all charges in cgroup. Currently, this is maintained for test.
>>  
>> +The file memory.soft_limit_in_bytes allows users to set soft limits. A soft
>> +limit is set in a manner similar to limit. The limit feature described
>> +earlier is a hard limit, a group can never exceed it's hard limit. A soft
> 
>                           ;  [or: ". A group ..."]


Will do

> and s/it's/its/
> 

Thanks, I seem to use it's instead of its at times. I'll double check next time

>> +limit on the other hand can be exceeded. A group will be shrunk back
>> +to it's soft limit, when there is memory pressure/contention.
> 
>       its  [it's == it is]
> 
>> +
>> +Ideally the soft limit should always be set to a value smaller than the
>> +hard limit. However, the code does not force the user to do so. The soft
>> +limit can be greater than the hard limit; then the soft limit has
>> +no meaning in that setup, since the group will alwasy be restrained to its
> 
>                                                   always
> 

Will fix

>> +hard limit.
>> +
>> +Example setting of soft limit
>> +
>> +# echo -n 100M > memory.soft_limit_in_bytes
>> +
>>  4. Testing
> 

Thanks for helping us keep the documentation readable.

-- 
	Warm Regards,
	Balbir Singh
	Linux Technology Center
	IBM, ISTL

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>