* [PATCH] latencytop: fix memory leak on latency proc file
@ 2008-02-14 18:27 Hiroshi Shimamoto
0 siblings, 0 replies; only message in thread
From: Hiroshi Shimamoto @ 2008-02-14 18:27 UTC (permalink / raw)
To: linux-kernel; +Cc: Arjan van de Ven, Ingo Molnar
From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
At lstats_open(), calling get_proc_task() gets task struct, but it never put.
put_task_struct() should be called when releasing.
Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
---
fs/proc/base.c | 11 ++++++++++-
1 files changed, 10 insertions(+), 1 deletions(-)
diff --git a/fs/proc/base.c b/fs/proc/base.c
index 1710b03..dc651a9 100644
--- a/fs/proc/base.c
+++ b/fs/proc/base.c
@@ -360,6 +360,15 @@ static int lstats_open(struct inode *inode, struct file *file)
return ret;
}
+static int lstats_release(struct inode *inode, struct file *file)
+{
+ struct seq_file *m = file->private_data;
+ struct task_struct *task = m->private;
+
+ put_task_struct(task);
+ return single_release(inode, file);
+}
+
static ssize_t lstats_write(struct file *file, const char __user *buf,
size_t count, loff_t *offs)
{
@@ -378,7 +387,7 @@ static const struct file_operations proc_lstats_operations = {
.read = seq_read,
.write = lstats_write,
.llseek = seq_lseek,
- .release = single_release,
+ .release = lstats_release,
};
#endif
--
1.5.3.8
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2008-02-14 18:27 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-02-14 18:27 [PATCH] latencytop: fix memory leak on latency proc file Hiroshi Shimamoto
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.