All of lore.kernel.org
 help / color / mirror / Atom feed
From: Corey Minyard <minyard@acm.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Andrew Morton <akpm@osdl.org>,
	Konstantin Baydarov <kbaidarov@ru.mvista.com>,
	OpenIPMI Developers <openipmi-developer@lists.sourceforge.net>,
	Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [Openipmi-developer] [PATCH 3/4] IPMI: convert locked counters to atomics
Date: Fri, 15 Feb 2008 08:08:02 -0600	[thread overview]
Message-ID: <47B59CC2.20404@acm.org> (raw)
In-Reply-To: <1203083843.6855.44.camel@twins>

Peter Zijlstra wrote:
> On Thu, 2008-02-14 at 12:30 -0600, Corey Minyard wrote:
>
>   
>> +/* The command didn't have anyone waiting for it. */
>> +#define IPMI_STAT_unhandled_commands			23
>> +
>> +/* Invalid data in an event. */
>> +#define IPMI_STAT_invalid_events			24
>> +
>> +/* Events that were received with the proper format. */
>> +#define IPMI_STAT_events				25
>> +
>> +/* When you add a statistic, you must update this value. */
>> +#define IPMI_NUM_STATS					26
>>     
>
> This shouts enum to me..
>   
Someone else asked about this, and I wasn't too sure.  It seems from the 
CodingStyle document that enums are preferred for things like this, but 
I current kernel code seems a mixed bag.  An enum is cleaner and more 
reliable, IMHO.  I'll convert it, I think.

Thanks,

-corey

  reply	other threads:[~2008-02-15 14:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-14 18:30 [PATCH 3/4] IPMI: convert locked counters to atomics Corey Minyard
2008-02-14 19:11 ` Andrew Morton
2008-02-14 19:33   ` Corey Minyard
2008-02-14 20:23     ` Andrew Morton
2008-02-15 13:57 ` Peter Zijlstra
2008-02-15 14:08   ` Corey Minyard [this message]
2008-02-16 16:44 ` [Openipmi-developer] " Matt Domsch
2008-02-20 15:20   ` Corey Minyard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47B59CC2.20404@acm.org \
    --to=minyard@acm.org \
    --cc=akpm@osdl.org \
    --cc=kbaidarov@ru.mvista.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=openipmi-developer@lists.sourceforge.net \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.