All of lore.kernel.org
 help / color / mirror / Atom feed
From: Corey Minyard <minyard@acm.org>
To: Matt Domsch <Matt_Domsch@dell.com>
Cc: Andrew Morton <akpm@osdl.org>,
	Konstantin Baydarov <kbaidarov@ru.mvista.com>,
	OpenIPMI Developers <openipmi-developer@lists.sourceforge.net>,
	Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [Openipmi-developer] [PATCH 3/4] IPMI: convert locked counters to atomics
Date: Wed, 20 Feb 2008 09:20:35 -0600	[thread overview]
Message-ID: <47BC4543.2050503@acm.org> (raw)
In-Reply-To: <20080216164434.GC13922@auslistsprd01.us.dell.com>

Matt Domsch wrote:
> On Thu, Feb 14, 2008 at 12:30:51PM -0600, Corey Minyard wrote:
>   
>> From: Konstantin Baydarov <kbaidarov@ru.mvista.com>
>>
>> Atomics are a lot more efficient and neat than using a lock.
>>     
>
> per_cpu variables are a lot more efficient and neat than using locks
> for simple statistics.  no cache line bouncing to increment the
> counter.  Are these read so often that atomics are really better?
>   
I agree, I'll put this in the plan for the future.  I don't have time to 
do it at this point, but the changes made in these patches should make 
it easy to change in the future.

Thanks,

-corey

      reply	other threads:[~2008-02-20 15:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-14 18:30 [PATCH 3/4] IPMI: convert locked counters to atomics Corey Minyard
2008-02-14 19:11 ` Andrew Morton
2008-02-14 19:33   ` Corey Minyard
2008-02-14 20:23     ` Andrew Morton
2008-02-15 13:57 ` Peter Zijlstra
2008-02-15 14:08   ` [Openipmi-developer] " Corey Minyard
2008-02-16 16:44 ` Matt Domsch
2008-02-20 15:20   ` Corey Minyard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47BC4543.2050503@acm.org \
    --to=minyard@acm.org \
    --cc=Matt_Domsch@dell.com \
    --cc=akpm@osdl.org \
    --cc=kbaidarov@ru.mvista.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=openipmi-developer@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.