All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 4/7] cgroup: fix memory leak in cgroup_get_sb()
@ 2008-02-18  5:49 Li Zefan
  2008-02-20  3:04 ` Paul Menage
       [not found] ` <47B91C7F.6080602-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
  0 siblings, 2 replies; 4+ messages in thread
From: Li Zefan @ 2008-02-18  5:49 UTC (permalink / raw)
  To: Andrew Morton; +Cc: Paul Menage, KAMEZAWA Hiroyuki, LKML, containers

opts.release_agent is not kfree()ed in all necessary places.

Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
---
 kernel/cgroup.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index 0c35022..aa76bbd 100644
--- a/kernel/cgroup.c
+++ b/kernel/cgroup.c
@@ -961,8 +961,11 @@ static int cgroup_get_sb(struct file_system_type *fs_type,
 	}
 
 	root = kzalloc(sizeof(*root), GFP_KERNEL);
-	if (!root)
+	if (!root) {
+		if (opts.release_agent)
+			kfree(opts.release_agent);
 		return -ENOMEM;
+	}
 
 	init_cgroup_root(root);
 	root->subsys_bits = opts.subsys_bits;
-- 
1.5.4.rc3


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH 4/7] cgroup: fix memory leak in cgroup_get_sb()
@ 2008-02-18  5:49 Li Zefan
  0 siblings, 0 replies; 4+ messages in thread
From: Li Zefan @ 2008-02-18  5:49 UTC (permalink / raw)
  To: Andrew Morton
  Cc: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA,
	Paul Menage, LKML

opts.release_agent is not kfree()ed in all necessary places.

Signed-off-by: Li Zefan <lizf-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
---
 kernel/cgroup.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index 0c35022..aa76bbd 100644
--- a/kernel/cgroup.c
+++ b/kernel/cgroup.c
@@ -961,8 +961,11 @@ static int cgroup_get_sb(struct file_system_type *fs_type,
 	}
 
 	root = kzalloc(sizeof(*root), GFP_KERNEL);
-	if (!root)
+	if (!root) {
+		if (opts.release_agent)
+			kfree(opts.release_agent);
 		return -ENOMEM;
+	}
 
 	init_cgroup_root(root);
 	root->subsys_bits = opts.subsys_bits;
-- 
1.5.4.rc3

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH 4/7] cgroup: fix memory leak in cgroup_get_sb()
       [not found] ` <47B91C7F.6080602-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
@ 2008-02-20  3:04   ` Paul Menage
  0 siblings, 0 replies; 4+ messages in thread
From: Paul Menage @ 2008-02-20  3:04 UTC (permalink / raw)
  To: Li Zefan
  Cc: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA,
	Andrew Morton, LKML

On Feb 17, 2008 9:49 PM, Li Zefan <lizf-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org> wrote:
> opts.release_agent is not kfree()ed in all necessary places.
>
> Signed-off-by: Li Zefan <lizf-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>

Acked-by: Paul Menage <menage-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>

Good catch, although hopefully something that would be extremely rare
in practice.

Thanks,

Paul

> ---
>  kernel/cgroup.c |    5 ++++-
>  1 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/kernel/cgroup.c b/kernel/cgroup.c
> index 0c35022..aa76bbd 100644
> --- a/kernel/cgroup.c
> +++ b/kernel/cgroup.c
> @@ -961,8 +961,11 @@ static int cgroup_get_sb(struct file_system_type *fs_type,
>         }
>
>         root = kzalloc(sizeof(*root), GFP_KERNEL);
> -       if (!root)
> +       if (!root) {
> +               if (opts.release_agent)
> +                       kfree(opts.release_agent);
>                 return -ENOMEM;
> +       }
>
>         init_cgroup_root(root);
>         root->subsys_bits = opts.subsys_bits;
> --
> 1.5.4.rc3
>
>

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH 4/7] cgroup: fix memory leak in cgroup_get_sb()
  2008-02-18  5:49 [PATCH 4/7] cgroup: fix memory leak in cgroup_get_sb() Li Zefan
@ 2008-02-20  3:04 ` Paul Menage
       [not found] ` <47B91C7F.6080602-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
  1 sibling, 0 replies; 4+ messages in thread
From: Paul Menage @ 2008-02-20  3:04 UTC (permalink / raw)
  To: Li Zefan; +Cc: Andrew Morton, KAMEZAWA Hiroyuki, LKML, containers

On Feb 17, 2008 9:49 PM, Li Zefan <lizf@cn.fujitsu.com> wrote:
> opts.release_agent is not kfree()ed in all necessary places.
>
> Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>

Acked-by: Paul Menage <menage@google.com>

Good catch, although hopefully something that would be extremely rare
in practice.

Thanks,

Paul

> ---
>  kernel/cgroup.c |    5 ++++-
>  1 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/kernel/cgroup.c b/kernel/cgroup.c
> index 0c35022..aa76bbd 100644
> --- a/kernel/cgroup.c
> +++ b/kernel/cgroup.c
> @@ -961,8 +961,11 @@ static int cgroup_get_sb(struct file_system_type *fs_type,
>         }
>
>         root = kzalloc(sizeof(*root), GFP_KERNEL);
> -       if (!root)
> +       if (!root) {
> +               if (opts.release_agent)
> +                       kfree(opts.release_agent);
>                 return -ENOMEM;
> +       }
>
>         init_cgroup_root(root);
>         root->subsys_bits = opts.subsys_bits;
> --
> 1.5.4.rc3
>
>

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-02-20  3:04 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-02-18  5:49 [PATCH 4/7] cgroup: fix memory leak in cgroup_get_sb() Li Zefan
2008-02-20  3:04 ` Paul Menage
     [not found] ` <47B91C7F.6080602-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2008-02-20  3:04   ` Paul Menage
  -- strict thread matches above, loose matches on Subject: below --
2008-02-18  5:49 Li Zefan

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.