From: Shi Weihua <shiwh@cn.fujitsu.com>
To: tony.luck@intel.com
Cc: linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org
Subject: [PATCH 5/5] signal(ia64_ia32): add a signal stack overflow check
Date: Mon, 18 Feb 2008 10:27:08 +0000 [thread overview]
Message-ID: <47B95D7C.1080005@cn.fujitsu.com> (raw)
The similar check has been added to x86_32(i386) in commit
id 83bd01024b1fdfc41d9b758e5669e80fca72df66.
So we add this check to ia64_ia32 and improve it a liitle bit in that
we need to check for stack overflow only when the signal is on stack.
Signed-off-by: Shi Weihua <shiwh@cn.fujitsu.com>
---
--- linux-2.6.25-rc2.orig/arch/ia64/ia32/ia32_signal.c 2008-02-16 04:57:20.000000000 +0800
+++ linux-2.6.25-rc2/arch/ia64/ia32/ia32_signal.c 2008-02-18 18:12:49.000000000 +0800
@@ -766,8 +766,19 @@ get_sigframe (struct k_sigaction *ka, st
/* This is the X/Open sanctioned signal stack switching. */
if (ka->sa.sa_flags & SA_ONSTACK) {
- if (!on_sig_stack(esp))
+ int onstack = sas_ss_flags(esp);
+
+ if (onstack = 0)
esp = current->sas_ss_sp + current->sas_ss_size;
+ else if (onstack = SS_ONSTACK) {
+ /*
+ * If we are on the alternate signal stack and would
+ * overflow it, don't return an always-bogus address
+ * instead so we will die with SIGSEGV.
+ */
+ if (!likely(on_sig_stack(esp - frame_size)))
+ return (void __user *) -1L;
+ }
}
/* Legacy stack switching not supported */
WARNING: multiple messages have this Message-ID (diff)
From: Shi Weihua <shiwh@cn.fujitsu.com>
To: tony.luck@intel.com
Cc: linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org
Subject: [PATCH 5/5] signal(ia64_ia32): add a signal stack overflow check
Date: Mon, 18 Feb 2008 18:27:08 +0800 [thread overview]
Message-ID: <47B95D7C.1080005@cn.fujitsu.com> (raw)
The similar check has been added to x86_32(i386) in commit
id 83bd01024b1fdfc41d9b758e5669e80fca72df66.
So we add this check to ia64_ia32 and improve it a liitle bit in that
we need to check for stack overflow only when the signal is on stack.
Signed-off-by: Shi Weihua <shiwh@cn.fujitsu.com>
---
--- linux-2.6.25-rc2.orig/arch/ia64/ia32/ia32_signal.c 2008-02-16 04:57:20.000000000 +0800
+++ linux-2.6.25-rc2/arch/ia64/ia32/ia32_signal.c 2008-02-18 18:12:49.000000000 +0800
@@ -766,8 +766,19 @@ get_sigframe (struct k_sigaction *ka, st
/* This is the X/Open sanctioned signal stack switching. */
if (ka->sa.sa_flags & SA_ONSTACK) {
- if (!on_sig_stack(esp))
+ int onstack = sas_ss_flags(esp);
+
+ if (onstack == 0)
esp = current->sas_ss_sp + current->sas_ss_size;
+ else if (onstack == SS_ONSTACK) {
+ /*
+ * If we are on the alternate signal stack and would
+ * overflow it, don't return an always-bogus address
+ * instead so we will die with SIGSEGV.
+ */
+ if (!likely(on_sig_stack(esp - frame_size)))
+ return (void __user *) -1L;
+ }
}
/* Legacy stack switching not supported */
next reply other threads:[~2008-02-18 10:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-18 10:27 Shi Weihua [this message]
2008-02-18 10:27 ` [PATCH 5/5] signal(ia64_ia32): add a signal stack overflow check Shi Weihua
2008-02-19 2:26 ` Shi Weihua
2008-02-19 2:26 ` Shi Weihua
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47B95D7C.1080005@cn.fujitsu.com \
--to=shiwh@cn.fujitsu.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.