From: Mike Travis <travis@sgi.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>, Andi Kleen <ak@suse.de>,
Christoph Lameter <clameter@sgi.com>,
Jack Steiner <steiner@sgi.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Andy Whitcroft <apw@shadowen.org>,
Randy Dunlap <rdunlap@xenotime.net>,
Joel Schopp <jschopp@austin.ibm.com>
Subject: Re: [PATCH 1/2] x86_64: Fold pda into per cpu area v3
Date: Wed, 20 Feb 2008 10:57:26 -0800 [thread overview]
Message-ID: <47BC7816.2030008@sgi.com> (raw)
In-Reply-To: <20080220120747.GA13695@elte.hu>
Ingo Molnar wrote:
> * Mike Travis <travis@sgi.com> wrote:
>
>> * Declare the pda as a per cpu variable. This will move the pda area
>> to an address accessible by the x86_64 per cpu macros.
>> Subtraction of __per_cpu_start will make the offset based from the
>> beginning of the per cpu area. Since %gs is pointing to the pda,
>> it will then also point to the per cpu variables and can be
>> accessed thusly:
>>
>> %gs:[&per_cpu_xxxx - __per_cpu_start]
>
> randconfig QA on x86.git found a crash on x86.git#testing with
> nmi_watchdog=2 (config attached) - and i bisected it down to this patch.
>
> config and crashlog attached. You can pick up x86.git#testing via:
>
> http://people.redhat.com/mingo/x86.git/README
>
> (since i had to hand-merge the patch when integrating it, i've attached
> the merged version below.)
>
> Ingo
>
I must need some different test machines as my AMD box does not fail with
either yours or Thomas's configs, and the Intel box complains about the
PCI-e e1000 driver and dies. I'll see about configuring a new box.
Did you try Eric's patch to see if that fixed the failure?
Thanks,
Mike
WARNING: multiple messages have this Message-ID (diff)
From: Mike Travis <travis@sgi.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>, Andi Kleen <ak@suse.de>,
Christoph Lameter <clameter@sgi.com>,
Jack Steiner <steiner@sgi.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Andy Whitcroft <apw@shadowen.org>,
Randy Dunlap <rdunlap@xenotime.net>,
Joel Schopp <jschopp@austin.ibm.com>
Subject: Re: [PATCH 1/2] x86_64: Fold pda into per cpu area v3
Date: Wed, 20 Feb 2008 10:57:26 -0800 [thread overview]
Message-ID: <47BC7816.2030008@sgi.com> (raw)
In-Reply-To: <20080220120747.GA13695@elte.hu>
Ingo Molnar wrote:
> * Mike Travis <travis@sgi.com> wrote:
>
>> * Declare the pda as a per cpu variable. This will move the pda area
>> to an address accessible by the x86_64 per cpu macros.
>> Subtraction of __per_cpu_start will make the offset based from the
>> beginning of the per cpu area. Since %gs is pointing to the pda,
>> it will then also point to the per cpu variables and can be
>> accessed thusly:
>>
>> %gs:[&per_cpu_xxxx - __per_cpu_start]
>
> randconfig QA on x86.git found a crash on x86.git#testing with
> nmi_watchdog=2 (config attached) - and i bisected it down to this patch.
>
> config and crashlog attached. You can pick up x86.git#testing via:
>
> http://people.redhat.com/mingo/x86.git/README
>
> (since i had to hand-merge the patch when integrating it, i've attached
> the merged version below.)
>
> Ingo
>
I must need some different test machines as my AMD box does not fail with
either yours or Thomas's configs, and the Intel box complains about the
PCI-e e1000 driver and dies. I'll see about configuring a new box.
Did you try Eric's patch to see if that fixed the failure?
Thanks,
Mike
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-02-20 18:57 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-19 20:33 [PATCH 0/2] x86: Optimize percpu accesses v3 Mike Travis
2008-02-19 20:33 ` Mike Travis
2008-02-19 20:33 ` [PATCH 1/2] x86_64: Fold pda into per cpu area v3 Mike Travis
2008-02-19 20:33 ` Mike Travis
2008-02-20 12:07 ` Ingo Molnar
2008-02-20 13:16 ` Eric Dumazet
2008-02-20 13:16 ` Eric Dumazet
2008-02-20 15:54 ` Mike Travis
2008-02-20 15:54 ` Mike Travis
2008-02-20 18:57 ` Mike Travis [this message]
2008-02-20 18:57 ` Mike Travis
2008-02-19 20:33 ` [PATCH 2/2] x86_64: Cleanup non-smp usage of cpu maps v3 Mike Travis
2008-02-19 20:33 ` Mike Travis
2008-03-04 1:02 ` Andrew Morton
2008-03-04 1:02 ` Andrew Morton
2008-03-04 1:30 ` Andrew Morton
2008-03-04 1:30 ` Andrew Morton
2008-03-04 8:35 ` Ingo Molnar
2008-03-04 8:35 ` Ingo Molnar
2008-03-05 0:45 ` Andrew Morton
2008-03-05 0:45 ` Andrew Morton
2008-03-04 13:21 ` Mike Travis
2008-03-04 13:21 ` Mike Travis
2008-02-20 9:15 ` [PATCH 0/2] x86: Optimize percpu accesses v3 Ingo Molnar
2008-02-20 9:15 ` Ingo Molnar
2008-02-20 15:28 ` Mike Travis
2008-02-20 15:28 ` Mike Travis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47BC7816.2030008@sgi.com \
--to=travis@sgi.com \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=apw@shadowen.org \
--cc=clameter@sgi.com \
--cc=jschopp@austin.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@elte.hu \
--cc=rdunlap@xenotime.net \
--cc=steiner@sgi.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.